Add support for looping over lists in OTTL #37993
Draft
+1,057
−397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic scaffolding of Expr[_} that will construct a new Slice using an existing one.
Add simplistic test to verify basics work. Need to sort through more advanced grammar tests later.
- Hackily construct new Parser for list comprehension evaluation - Delegate from existing parser to nested context to avoid reflection issues TODOs - Robust Testing - Ensuring we didn't miss other places lists could exist - Figuring out how to safely deal with recursion of names.
github-actions
bot
requested review from
bogdandrutu,
edmocosta,
evan-bradley,
kentquirk and
TylerHelmuth
- Needed new wrapping key/context path features - Needed hacks on context inference and path parsing for loop expressions - Gunked up visitor pattern for List compmrehensions Got test working end to end...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds list-comprehension support to OTTL. As of this PR you can successfully write expressions like:
[x*2 for x in mylist if x > 0]Link to tracking issue
Fixes #29289
Testing
Documentation
Next Steps