Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Semantic Convention schema migrations #8495

Open
MovieStoreGuy opened this issue Jan 25, 2022 · 8 comments
Open

Support for Semantic Convention schema migrations #8495

MovieStoreGuy opened this issue Jan 25, 2022 · 8 comments
Assignees
Labels
never stale Issues marked with this label will be never staled and automatically removed

Comments

@MovieStoreGuy
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As means of supporting varies versions of the semantic convention, it would be nice to emit only one version of the semantic convention and migrate anyone using an older version to target X.

Describe the solution you'd like
The collector has the ability to be configured to emit a given version of the semantic convention and translate older attributes into the new attributes or resource names (metric name, span name) to the updated convention.

Describe alternatives you've considered
Ideally this should be resolve by pushing out auto instrumentation and letting the apps upgrade as there is a new version, but isn't always easier to get right. It would also help getting large monolith projects onto the new semantic conventions but schema migrations.

Additional context
This was discussed in the last APAC instrumentation meeting and is a nice to have to help allow fast iterations on the semantic convention.

cc @tedsuo

@Aneurysm9
Copy link
Member

https://github.com/open-telemetry/opentelemetry-go/tree/main/schema was created with the goal of enabling this type of translation, both within the SDK and in the collector.

@MovieStoreGuy
Copy link
Contributor Author

Hey @alolita ,

could I ask you to move this to the contrib repo?

@jpkrohling jpkrohling transferred this issue from open-telemetry/opentelemetry-collector Mar 16, 2022
@jpkrohling
Copy link
Member

could I ask you to move this to the contrib repo?

Done!

@MovieStoreGuy
Copy link
Contributor Author

Love your work @jpkrohling <3

tigrannajaryan pushed a commit that referenced this issue May 2, 2022
**Description:**
As part of the [accepted specification](https://github.com/open-telemetry/opentelemetry-specification/blob/e16e1a781bdf62a8fcfa1a12963844749de23e7a/specification/schemas/overview.md#collector-assisted-schema-transformation), there needs to be a processor within the collector that is able to allow for transformations of semantic convention versions . This is my initial draft, I wrote this before https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/8344/files shared their solution to it.

**Link to tracking Issue:**
#8495
Original raised in the collector but should be shifted to the contrib a I can tell.

**Testing:**
It currently does nothing and there is the initial testing set up within the components.

**Documentation:** 
Added a minimal README, will expand upon it once more work has been added to the collector.
djaglowski pushed a commit to djaglowski/opentelemetry-collector-contrib that referenced this issue May 10, 2022
**Description:**
As part of the [accepted specification](https://github.com/open-telemetry/opentelemetry-specification/blob/e16e1a781bdf62a8fcfa1a12963844749de23e7a/specification/schemas/overview.md#collector-assisted-schema-transformation), there needs to be a processor within the collector that is able to allow for transformations of semantic convention versions . This is my initial draft, I wrote this before https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/8344/files shared their solution to it.

**Link to tracking Issue:**
open-telemetry#8495
Original raised in the collector but should be shifted to the contrib a I can tell.

**Testing:**
It currently does nothing and there is the initial testing set up within the components.

**Documentation:** 
Added a minimal README, will expand upon it once more work has been added to the collector.
@codeboten codeboten added the needs triage New item requiring triage label Sep 16, 2022
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Nov 16, 2022
@MovieStoreGuy
Copy link
Contributor Author

Sorry, I am back to working on this. I just need to rebase and catch up on what i have missed.

@tigrannajaryan tigrannajaryan removed the needs triage New item requiring triage label Nov 21, 2022
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Jan 23, 2023
@MovieStoreGuy MovieStoreGuy added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Jan 23, 2023
@MrAlias
Copy link
Contributor

MrAlias commented Aug 7, 2023

I created https://github.com/MrAlias/otel-schema-utils to help with opentelemetry-go users who needed to translate resources created at different schema versions.

It is not a complete translation suite, but I thought I would post it here in case it would be helpful to anyone trying to resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
never stale Issues marked with this label will be never staled and automatically removed
Projects
None yet
Development

No branches or pull requests

6 participants