You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
I have see current code. I know span name will display method pattern in http standard library with go greater or equal 1.22.0, reference code:
But I have found that gin 1.9.1 trace span name only show method because of gin.Context internal http.Request struct field pat is nil, is there can get gin.Context.fullPath field in it?
Describe the solution you'd like
support gin.Context.fullPath field in span name. I am not good at ebpf and I have try to read gin.Context.fullPath from ebpf, but failed.
The text was updated successfully, but these errors were encountered:
The same problem I've met. I think the code that causes this problem is in internal/pkg/instrumentation/bpf/net/http/server/bpf/probe.bpf.c:
int ret = bpf_probe_read(&pat_ptr, sizeof(pat_ptr), (void *)(req_ptr + req_pat_pos));
pat_ptr is 0.
Additionally, it seems that the same issue will ocuur in net/http package rather than just Gin. You can try the httpPlusdb on a Linux/amd64 virtual machine(not in a container).
Is your feature request related to a problem? Please describe.
I have see current code. I know span name will display
method pattern
in http standard library with go greater or equal1.22.0
, reference code:opentelemetry-go-instrumentation/internal/pkg/instrumentation/bpf/net/http/server/probe.go
Lines 206 to 210 in 57ae946
But I have found that gin
1.9.1
trace span name only showmethod
because of gin.Context internal http.Request struct fieldpat
is nil, is there can get gin.Context.fullPath field in it?Describe the solution you'd like
support gin.Context.fullPath field in span name. I am not good at ebpf and I have try to read gin.Context.fullPath from ebpf, but failed.
The text was updated successfully, but these errors were encountered: