Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Integrating Laravel with sqlcommenter #1346

Open
moeyashi opened this issue Jul 12, 2024 · 2 comments
Open

[Feature Request] Integrating Laravel with sqlcommenter #1346

moeyashi opened this issue Jul 12, 2024 · 2 comments
Labels
help wanted This issue is looking for someone to work on it instrumentation Issues that relate to instrumentation for OpenTelemetry PHP

Comments

@moeyashi
Copy link

Before opening a feature request against this repo, consider whether the feature should/could be implemented in the other OpenTelemetry client libraries. If so, please open an issue in opentelemetry-specification first.

This feature is implemented in python, django. And in the past there was a library for Laravel.
https://github.com/open-telemetry/opentelemetry-sqlcommenter/blob/main/docs/python/django/README.md/#installation
https://github.com/google/sqlcommenter/tree/master/php/sqlcommenter-php/packages/sqlcommenter-laravel

Is your feature request related to a problem?

It would be useful to add comments to the SQL.
#1345

Describe the solution you'd like

Integrating Laravel with sqlcommenter.

Describe alternatives you've considered

I'm currently forking and using the google repository.
https://github.com/moeyashi/sqlcommenter/tree/update-opentelemetry

Additional context

It's probably not something we'll implement right away.

I think we'll align our approach with other languages ​​through discussions on open-telemetry/opentelemetry-specification#3560 and open-telemetry/opentelemetry-sqlcommenter#5.

@brettmc
Copy link
Collaborator

brettmc commented Jul 12, 2024

@moeyashi are you planning to work on this? I can assign it to you. Otherwise, I'll add a help-wanted label.

@moeyashi
Copy link
Author

@brettmc I don't have time to work on this for a several months so please label it.

@brettmc brettmc added help wanted This issue is looking for someone to work on it instrumentation Issues that relate to instrumentation for OpenTelemetry PHP labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted This issue is looking for someone to work on it instrumentation Issues that relate to instrumentation for OpenTelemetry PHP
Projects
None yet
Development

No branches or pull requests

2 participants