Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: automatic instrumentation for asyncclick #3318

Open
jomcgi opened this issue Mar 2, 2025 · 0 comments · May be fixed by #3319
Open

Feature Request: automatic instrumentation for asyncclick #3318

jomcgi opened this issue Mar 2, 2025 · 0 comments · May be fixed by #3319

Comments

@jomcgi
Copy link
Contributor

jomcgi commented Mar 2, 2025

What problem do you want to solve?

asyncclick is an async fork of click.
The existing click autoinstrumentation is compatible if you patch the import:
import click -> import asyncclick as click

Describe the solution you'd like

A separate autoinstrumentation package for the async fork of click.

Describe alternatives you've considered

Coupling this to the existing click autoinstrumentation adds an unnecessary dependency for most existing users and could become more complex as the libraries diverge.
A little duplication is better than a little coupling.

Additional Context

Related issue for a project using asyncclick:
tahnok/colmi_r02_client#38

Would you like to implement a fix?

Yes

@jomcgi jomcgi linked a pull request Mar 2, 2025 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant