Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActiveStorage instrumentation #1307

Open
ymtdzzz opened this issue Dec 18, 2024 · 1 comment
Open

ActiveStorage instrumentation #1307

ymtdzzz opened this issue Dec 18, 2024 · 1 comment

Comments

@ymtdzzz
Copy link
Contributor

ymtdzzz commented Dec 18, 2024

related: #298

We can add instrumentation for ActiveStorage by subscribing to *.active_storage events.
https://guides.rubyonrails.org/active_support_instrumentation.html#active-storage

The ActionMailer instrumentation could be helpful.
https://github.com/open-telemetry/opentelemetry-ruby-contrib/tree/main/instrumentation/action_mailer

When I play around with these events, I feel like we can get useful information.
image
@ymtdzzz ymtdzzz mentioned this issue Dec 20, 2024
Merged
@ymtdzzz
Copy link
Contributor Author

ymtdzzz commented Jan 15, 2025

I have created a PR to add ActiveStorage instrumentation and would be happy to review it when someone has time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ymtdzzz