Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client uses defaultFrequency = 24kHz on different formats than pcm16 #69

Open
ovistoica opened this issue Nov 12, 2024 · 0 comments
Open

Comments

@ovistoica
Copy link

Hello, I noticed that betweem client.js or conversation.js the defaultFrequency at which we calculate how much audio to truncate is always 24kHz regardless of the audio format.

Shouldn't this be updated if the input/output frequency changes? For example if audio format is changed to MULAW for phone calls, the defaultFrequency should change to 8KHz.

Let me know if I'm wrong here, if not, I'm happy to open a PR

@ovistoica ovistoica changed the title Using defaultFrequency = 24kHz on different formats than pcm16 Client uses defaultFrequency = 24kHz on different formats than pcm16 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant