Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for infiniteQueryOptions and useSuspenseInfiniteQuery #2077

Closed
minchodang opened this issue Jan 2, 2025 · 6 comments
Closed

Support for infiniteQueryOptions and useSuspenseInfiniteQuery #2077

minchodang opened this issue Jan 2, 2025 · 6 comments
Assignees
Labels
enhancement New feature or request openapi-react-query Relevant to openapi-react-query PRs welcome PRs are welcome to solve this issue!

Comments

@minchodang
Copy link

Hello,

First of all, thank you for developing the open-source project based on OpenAPI.

While using it recently, I noticed that infiniteQueryOptions and useSuspenseInfiniteQuery are not yet supported, which was disappointing.

If you are not currently working on these features, I would like to contribute to their implementation.

I would appreciate your feedback.

Happy New Year!

@minchodang minchodang added enhancement New feature or request openapi-react-query Relevant to openapi-react-query labels Jan 2, 2025
@drwpow drwpow self-assigned this Jan 3, 2025
@drwpow drwpow added the PRs welcome PRs are welcome to solve this issue! label Jan 3, 2025
@drwpow
Copy link
Contributor

drwpow commented Jan 3, 2025

We’d happily accept a PR for this, thank you!

Normally it helps to have more of a proposal in case there are multiple ways to accomplish the goal, but to me this seems like just adding functionality that TanStack Query already has, so I’m not sure if it would be all that opinionated. But in case while working on a PR, you find a decision that’s not straightforward, or there may be tradeoffs, we’d be happy to discuss! Otherwise will await a PR 🙂

@minchodang
Copy link
Author

Great, I’ll finish the work and submit a PR soon.
In fact, I noticed that useInfiniteQuery was already introduced via a PR(#1881 ).
Additionally, seeing that general suspenseQuery and queryOptions are already supported, I thought it would be a good idea to introduce this for the sake of consistency as well.

Thank you for the warm welcome.
I’ll see you again in the PR!

@drwpow
Copy link
Contributor

drwpow commented Jan 4, 2025

Oh shoot I forgot there was an open PR already (I could have sworn someone had mentioned it, but neither came up in search 😅)

Since there’s already an issue, I’ll close as a duplicate of #1828

@drwpow drwpow closed this as completed Jan 4, 2025
@drwpow
Copy link
Contributor

drwpow commented Jan 4, 2025

@minchodang also it seems that PR has stalled for a while, so please feel free to start a new PR where #1881 leaves off. Be sure to incorporate the other feedback there. We can then close that PR in favor of yours (and close #1828 as well)

@minchodang
Copy link
Author

@drwpow Ok. good.
After I finished work, I'll mentioned and link at this PR's(#1881 , #1828).

@lukasedw
Copy link
Contributor

Hey guys, I continued the PR made by @jungwoo3490 here #2117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request openapi-react-query Relevant to openapi-react-query PRs welcome PRs are welcome to solve this issue!
Projects
None yet
Development

No branches or pull requests

3 participants