-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extend the profile fields with the already existing extended_profile_fields #1167
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @bra-i-am! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
5503f7a
to
177091e
Compare
@bra-i-am looks like there are some failing tests, can you have a look? Also, I've invited you to the triage team which will allow tests to run automatically. Please accept that invite. |
Description
This PR aims to allow the extension of the default profile fields by using the
extended_profile_fields
feature with a custom form app like the exampleMain changes
extended_profile_field
settings attribute (it is only covered checkbox, text and select fields)mfe_context
API)fieldValue
s from theextended_profile
account prop to theextended_profile_fields
attributes since the data is fetchedHow Has This Been Tested?
Sumac
environmenttutor mounts add /path/to/cloned/mfe
tutor mounts add lms:/path/to/cloned/custom-form-app:/openedx/extra-deps
and install it usingtutor dev exec lms pip install -e ../extra-deps/custom-form-app
Site Configurations > local.openedx.io:8000
:tutor dev restart
Screenshots/sandbox (optional):