You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If a 3rd party, providing task runner commands, wants to extend \OpenEuropa\TaskRunner\Tests\AbstractTest, it cannot reuse most of its methods, such as ::getClassLoader(), ::getFixtureContent(), ::getSandboxRoot(), because they are hardcoding paths. But when openeuropa/task-runner is a dependency, under vendor/, the paths are no more correct.
Problem
If a 3rd party, providing task runner commands, wants to extend
\OpenEuropa\TaskRunner\Tests\AbstractTest
, it cannot reuse most of its methods, such as::getClassLoader()
,::getFixtureContent()
,::getSandboxRoot()
, because they are hardcoding paths. But whenopeneuropa/task-runner
is a dependency, undervendor/
, the paths are no more correct.For instance, the https://github.com/openeuropa/task-runner-changelog project had to override those methods, see https://github.com/openeuropa/task-runner-changelog/blob/bd01ccdf17fe7f9fe8465188d9f0cd7a1f219684/tests/ChangelogCommandTest.php, in order to reuse
AbstractTest
.Proposal
Make
\OpenEuropa\TaskRunner\Tests\AbstractTest
methods inheritable.The text was updated successfully, but these errors were encountered: