feat: fix and improve rate limit handling. #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (24.98%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
==========================================
- Coverage 25.27% 24.98% -0.30%
==========================================
Files 104 105 +1
Lines 12592 12734 +142
==========================================
- Hits 3183 3181 -2
- Misses 9145 9304 +159
+ Partials 264 249 -15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The SDK now retries on network errors and the default retry handling has been fixed for both the calls to the OpenFGA API and the API Token Issuer for those using ClientCredentials The SDK now also respects the rate limit headers (`Retry-After`) returned by the server and will retry the request after the specified time. If the header is not sent or on network errors, it will fall back to exponential backoff.
ewanharris
previously approved these changes
Mar 14, 2025
ewanharris
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK now respects the rate limit headers (
Retry-After) returned by the server and will retry the request after the specified time. If the header is not sent: for 429s, it will fall back to exponential backoff. For 5xxs, it will fall back to exponential backoff if the request does not modify state.Description
Generated from openfga/sdk-generator#506 pinned to this API commit: openfga/api@7c098f1, using
References
Closes: #177
Generated from openfga/sdk-generator#506
Review Checklist
main