Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the FAQ and redirect to ecosystem-wide FAQ #1934

Merged
merged 6 commits into from
Oct 2, 2024
Merged

Conversation

Yoshanuikabundi
Copy link
Collaborator

@Yoshanuikabundi Yoshanuikabundi commented Sep 10, 2024

See openforcefield/openff-docs#63, #1932. Closes #1848.

This doesn't add a redirect from the current FAQ URL to the new one - I'll add that by hand in RTD when I merge this.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.76%. Comparing base (31e4c4b) to head (028e4ff).
Report is 1 commits behind head on main.

Additional details and impacted files

@j-wags
Copy link
Member

j-wags commented Sep 12, 2024

I'm seeing one more link that needs to be updated in the logs -
generating indices... /home/docs/checkouts/readthedocs.org/user_builds/open-forcefield-toolkit/checkouts/1934/docs/users/molecule_cookbook.ipynb:130002: WARNING: 'myst' cross-reference target not found: '../faq.md#im-getting-stereochemistry-errors-when-loading-a-molecule-from-a-smiles-string' [myst.xref_missing]

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Yoshanuikabundi
Copy link
Collaborator Author

OK I've set up the FAQ so that each question can be linked to directly and I've added a commit here that fixes the Micromamba 2.0 issue. This should be good to go but the MacOS builds are going very slowly!

Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @Yoshanuikabundi!

@j-wags j-wags merged commit 58b0688 into main Oct 2, 2024
3 checks passed
@j-wags j-wags deleted the redirect-faq branch October 2, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update FAQ
2 participants