Skip to content

Commit f49b979

Browse files
authored
fix!: removed second auth header (#6)
1 parent bca47b1 commit f49b979

File tree

2 files changed

+10
-14
lines changed

2 files changed

+10
-14
lines changed

internal/server/handlerCategory.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,13 @@ func _categoryHandler(s *shared, req *http.Request, res *response) (*response, *
4646

4747
var config k8s.KubeConfig
4848
if data.ProjectName != "" && data.WorkspaceName != "" && data.McpName != "" {
49-
config, err = openmcp.GetControlPlaneKubeconfig(s.crateKube, data.ProjectName, data.WorkspaceName, data.McpName, data.CrateAuthorization, crateKubeconfig)
49+
config, err = openmcp.GetControlPlaneKubeconfig(s.crateKube, data.ProjectName, data.WorkspaceName, data.McpName, data.Authorization, crateKubeconfig)
5050
if err != nil {
5151
slog.Error("failed to get control plane api config", "err", err)
5252
return nil, NewInternalServerError("failed to get control plane api config")
5353
}
54-
if data.McpAuthorization != "" {
55-
config.SetUserToken(data.McpAuthorization)
54+
if data.Authorization != "" {
55+
config.SetUserToken(data.Authorization)
5656
}
5757
} else {
5858
slog.Error("either use %s: true or provide %s, %s and %s headers", useCrateClusterHeader, projectNameHeader, workspaceNameHeader, mcpName)

internal/server/handlerMain.go

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ const (
2121
projectNameHeader = "X-project"
2222
workspaceNameHeader = "X-workspace"
2323
mcpName = "X-mcp"
24-
mcpAuthHeader = "X-mcp-authorization"
2524
contextHeader = "X-context"
2625
useCrateClusterHeader = "X-use-crate"
2726
authorizationHeader = "Authorization"
@@ -36,7 +35,6 @@ var prohibitedRequestHeaders = []string{
3635
projectNameHeader,
3736
workspaceNameHeader,
3837
mcpName,
39-
mcpAuthHeader,
4038
contextHeader,
4139
authorizationHeader,
4240
"User-Agent",
@@ -54,10 +52,9 @@ type ExtractedRequestData struct {
5452
ProjectName string
5553
WorkspaceName string
5654
McpName string
57-
McpAuthorization string
5855
ContextName string
5956
UseCrateCluster bool
60-
CrateAuthorization string
57+
Authorization string
6158
Headers map[string][]string
6259
JQ string
6360
Category string
@@ -90,15 +87,15 @@ func mainHandler(s *shared, req *http.Request, res *response) (*response, *HttpE
9087
var config k8s.KubeConfig
9188
if data.UseCrateCluster {
9289
config = crateKubeconfig
93-
config.SetUserToken(data.CrateAuthorization)
90+
config.SetUserToken(data.Authorization)
9491
} else if data.ProjectName != "" && data.WorkspaceName != "" && data.McpName != "" {
95-
config, err = openmcp.GetControlPlaneKubeconfig(s.crateKube, data.ProjectName, data.WorkspaceName, data.McpName, data.CrateAuthorization, crateKubeconfig)
92+
config, err = openmcp.GetControlPlaneKubeconfig(s.crateKube, data.ProjectName, data.WorkspaceName, data.McpName, data.Authorization, crateKubeconfig)
9693
if err != nil {
9794
slog.Error("failed to get control plane api config", "err", err)
9895
return nil, NewInternalServerError("failed to get control plane api config")
9996
}
100-
if data.McpAuthorization != "" {
101-
config.SetUserToken(data.McpAuthorization)
97+
if data.Authorization != "" {
98+
config.SetUserToken(data.Authorization)
10299
}
103100
} else {
104101
slog.Error("either use %s: true or provide %s, %s and %s headers", useCrateClusterHeader, projectNameHeader, workspaceNameHeader, mcpName)
@@ -152,9 +149,8 @@ func extractRequestData(r *http.Request) (ExtractedRequestData, error) {
152149
ProjectName: r.Header.Get(projectNameHeader),
153150
WorkspaceName: r.Header.Get(workspaceNameHeader),
154151
ContextName: r.Header.Get(contextHeader),
155-
McpAuthorization: r.Header.Get(mcpAuthHeader),
156152
McpName: r.Header.Get(mcpName),
157-
CrateAuthorization: r.Header.Get(authorizationHeader),
153+
Authorization: r.Header.Get(authorizationHeader),
158154
JQ: r.Header.Get(jqHeader),
159155
Category: r.Header.Get(categoryHeader),
160156
}
@@ -170,7 +166,7 @@ func extractRequestData(r *http.Request) (ExtractedRequestData, error) {
170166
rd.UseCrateCluster = useCrateCluster
171167
}
172168

173-
if rd.CrateAuthorization == "" {
169+
if rd.Authorization == "" {
174170
return ExtractedRequestData{}, fmt.Errorf("%s header is required", authorizationHeader)
175171
}
176172

0 commit comments

Comments
 (0)