Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Oct 5, 2025

This PR contains the following updates:

Package Change Age Confidence
eslint-plugin-react-hooks (source) 5.2.0 -> 7.0.1 age confidence

Release Notes

facebook/react (eslint-plugin-react-hooks)

v7.0.1

Compare Source

v7.0.0

Compare Source

This release slims down presets to just 2 configurations (recommended and recommended-latest), and all compiler rules are enabled by default.

  • Breaking: Removed recommended-latest-legacy and flat/recommended configs. The plugin now provides recommended (legacy and flat configs with all recommended rules), and recommended-latest (legacy and flat configs with all recommended rules plus new bleeding edge experimental compiler rules). (@​poteto in #​34757)

v6.1.1

Compare Source

Note: 6.1.0 accidentally allowed use of recommended without flat config, causing errors when used with ESLint v9's defineConfig() helper. This has been fixed in 6.1.1.

v6.1.0

Compare Source

Note: Version 6.0.0 was mistakenly released and immediately deprecated and untagged on npm. This is the first official 6.x major release and includes breaking changes.

  • Breaking: Require Node.js 18 or newer. (@​michaelfaith in #​32458)
  • Breaking: Flat config is now the default recommended preset. Legacy config moved to recommended-legacy. (@​michaelfaith in #​32457)
  • New Violations: Disallow calling use within try/catch blocks. (@​poteto in #​34040)
  • New Violations: Disallow calling useEffectEvent functions in arbitrary closures. (@​jbrown215 in #​33544)
  • Handle React.useEffect in addition to useEffect in rules-of-hooks. (@​Ayc0 in #​34076)
  • Added react-hooks settings config option that to accept additionalEffectHooks that are used across exhaustive-deps and rules-of-hooks rules. (@​jbrown215) in #​34497

v6.0.0

Compare Source

Accidentally released. See 6.1.0 for the actual changes.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/major-react-monorepo branch 11 times, most recently from a876f29 to 5aac816 Compare October 12, 2025 01:42
@renovate renovate bot changed the title chore(deps): update dependency eslint-plugin-react-hooks to v6 chore(deps): update dependency eslint-plugin-react-hooks to v7 Oct 12, 2025
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch 2 times, most recently from 00ac5b5 to 6bb4306 Compare October 22, 2025 13:18
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch from 6bb4306 to 7ece9fb Compare October 27, 2025 19:33
@renovate renovate bot force-pushed the renovate/major-react-monorepo branch from 7ece9fb to af5ae56 Compare November 10, 2025 14:54
@renovate
Copy link
Contributor Author

renovate bot commented Nov 12, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@andreaskienle
Copy link
Contributor

andreaskienle commented Nov 12, 2025

The new lint rules complain about the following problems:

  • Cannot access refs during render which is discouraged by the official documentation:
    • The refs were only needed to connect the popover/menu with the opening button. I replaced the ref with useId() to make the connection which also works for UI5 web components
  • Cannot call impure function during render which is discouraged for the same reason (component functions should be pure)
    • We used Math.random to generate random names in the wizard; i moved this to the initialization function of useState()
  • Calling setState synchronously within an effect can trigger cascading renders
    • For dialogs, this happens when the state of a dialog was reset in a useEffect(…, [open]). I moved the reset logic from the effect into the onClose-event handler directly
    • In another instance, I removed the FadeVisibility component which had this error and replaced it with conditional rendering (i.e. without transitions). I'd say let's keep it simple for now.
    • In useGraph.ts I disabled the lint rule because the graph coding needs quite some refactoring anyway, especially when we remove the colours
    • For the YAML editor I also disabled the rule because the yaml coding is going to change soon anyway
  • Compilation Skipped: Use of incompatible library
    • Happened with watch of RHF; I replaced it with useWatch

Copilot finished reviewing on behalf of andreaskienle November 13, 2025 07:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 16 out of 17 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants