Skip to content

Commit 63a4c97

Browse files
Updated to support gradle version support in FindDependencies (#161)
* Updated to support gradle version support in FindDependencies * Update src/test/java/org/openrewrite/java/dependencies/FindDependencyTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 parent d63e034 commit 63a4c97

File tree

2 files changed

+48
-2
lines changed

2 files changed

+48
-2
lines changed

src/main/java/org/openrewrite/java/dependencies/FindDependency.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public TreeVisitor<?, ExecutionContext> getVisitor() {
7575

7676
final TreeVisitor<?, ExecutionContext> mavenFindDependency = new org.openrewrite.maven.search.FindDependency(groupId,artifactId,version,versionPattern)
7777
.getVisitor();
78-
final TreeVisitor<?, ExecutionContext> gradleFindDependency = new org.openrewrite.gradle.search.FindDependency(groupId, artifactId, configuration)
78+
final TreeVisitor<?, ExecutionContext> gradleFindDependency = new org.openrewrite.gradle.search.FindDependency(groupId, artifactId, configuration, version, versionPattern)
7979
.getVisitor();
8080

8181
@Override

src/test/java/org/openrewrite/java/dependencies/FindDependencyTest.java

Lines changed: 47 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class FindDependencyTest implements RewriteTest {
1919

2020
@Override
2121
public void defaults(RecipeSpec spec) {
22-
spec.recipe(new FindDependency("org.openrewrite", "rewrite-core", null, null, null));
22+
spec.recipe(new FindDependency("org.openrewrite", "rewrite-core", "8.0.0", null, null));
2323
}
2424

2525
@DocumentExample
@@ -60,6 +60,29 @@ void findMavenDependency() {
6060
);
6161
}
6262

63+
@Test
64+
void findMavenDependencyDoesNotFindWrongVersion() {
65+
rewriteRun(
66+
//language=xml
67+
pomXml(
68+
"""
69+
<project>
70+
<groupId>com.mycompany.app</groupId>
71+
<artifactId>my-app</artifactId>
72+
<version>1</version>
73+
<dependencies>
74+
<dependency>
75+
<groupId>org.openrewrite</groupId>
76+
<artifactId>rewrite-core</artifactId>
77+
<version>8.1.0</version>
78+
</dependency>
79+
</dependencies>
80+
</project>
81+
"""
82+
)
83+
);
84+
}
85+
6386
@Test
6487
void findGradleDependency() {
6588
rewriteRun(
@@ -95,4 +118,27 @@ void findGradleDependency() {
95118
)
96119
);
97120
}
121+
122+
@Test
123+
void findGradleDependencyDoesntFindWrongVersion() {
124+
rewriteRun(
125+
spec -> spec.beforeRecipe(withToolingApi()),
126+
//language=groovy
127+
buildGradle(
128+
"""
129+
plugins {
130+
id 'java-library'
131+
}
132+
133+
repositories {
134+
mavenCentral()
135+
}
136+
137+
dependencies {
138+
api "org.openrewrite:rewrite-core:8.1.0"
139+
}
140+
"""
141+
)
142+
);
143+
}
98144
}

0 commit comments

Comments
 (0)