Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A managed dependency with 'RELEASE' version is not resolved correctly #4983

Open
crankydillo opened this issue Feb 3, 2025 · 0 comments
Open
Labels
bug Something isn't working

Comments

@crankydillo
Copy link
Contributor

<version>RELEASE</version> doesn't get resolved to the latest release.

The POM I have below works if I use it with mvn:3.9.9.

What version of OpenRewrite are you using?

main branch, rewrite-maven module

How are you running OpenRewrite?

IDE

What is the smallest, simplest way to reproduce the problem?

Add the following to MavenParserTest:

    @Test
    @DisplayName("Using RELEASE for GAV version in dependency management")
    void releaseInDepMgmt() {
        rewriteRun(
          pomXml(
            """
              <project>
                <groupId>com.mycompany.app</groupId>
                <artifactId>my-app</artifactId>
                <version>1</version>
                
                <dependencyManagement>
                  <dependencies>
                     <dependency>
                      <groupId>org.springframework.boot</groupId>
                      <artifactId>spring-boot-dependencies</artifactId>
                      <version>RELEASE</version>
                      <type>pom</type>
                      <scope>import</scope>
                    </dependency>
                  </dependencies>
                </dependencyManagement>
                <dependencies>
                  <dependency>
                    <groupId>org.junit.jupiter</groupId>
                    <artifactId>junit-jupiter</artifactId>
                  </dependency>
                </dependencies>
              </project>
              """
          )
        );
    }

What did you see instead?

I expected no error, but got a failing test:

Caused by: org.openrewrite.maven.MavenDownloadingException: org.springframework.boot:spring-boot-dependencies:RELEASE failed. Unable to download POM: org.springframework.boot:spring-boot-dependencies:RELEASE. Tried repositories:
https://repo.maven.apache.org/maven2: HTTP 404
	at org.openrewrite.maven.internal.MavenPomDownloader.download(MavenPomDownloader.java:660)
	at org.openrewrite.maven.tree.ResolvedPom$Resolver.mergeDependencyManagement(ResolvedPom.java:812)
	at org.openrewrite.maven.tree.ResolvedPom$Resolver.resolveParentDependenciesRecursively(ResolvedPom.java:445)
	at org.openrewrite.maven.tree.ResolvedPom$Resolver.resolveParentsRecursively(ResolvedPom.java:397)
	at org.openrewrite.maven.tree.ResolvedPom$Resolver.resolve(ResolvedPom.java:368)
	at org.openrewrite.maven.tree.ResolvedPom.resolve(ResolvedPom.java:182)
	at org.openrewrite.maven.tree.Pom.resolve(Pom.java:193)
	at org.openrewrite.maven.tree.Pom.resolve(Pom.java:175)
	at org.openrewrite.maven.MavenParser.parseInputs(MavenParser.java:113)
	... 7 more
@crankydillo crankydillo added the bug Something isn't working label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant