ChangePackage doesn't handle classes with GWT JNSI methods

[auke-]

What version of OpenRewrite are you using?

I am using OpenRewrite v8.44.2 with the ChangePackage recipe.

What is the smallest, simplest way to reproduce the problem?

type: specs.openrewrite.org/v1beta/recipe
name: com.yourorg.ChangePackageExample
displayName: Rename package name example
recipeList:
  - org.openrewrite.java.ChangePackage:
      oldPackageName: old_package_name
      newPackageName: new_package_name

package old_package_name;
class A {
  native void alert(String msg) /*-{ $wnd.alert(msg); }-*/;
}

What did you expect to see?

package new_package_name;
class A {
  native void alert(String msg) /*-{ $wnd.alert(msg); }-*/;
}

What did you see instead?

OpenRewrite didn't touch the file. It seems like it ignores Java classes with native methods and/or trailing comment.

See reproducer

[timtebeek]

Thanks for the runnable report! Feel free to open up a draft PR; that makes it easier to pull into an IDEA and explore. We're not too strict on requiring an issue or working fix first.

[auke-]

Hmm... looks i've made some errror on my side, the reproducer isn't correct.

[auke-]

We did encounter issues with the ChangePackage recipe and it looked like is had to to with native methods. Will try to create a proper reproducer tomorrow. Do you have another channel for quick questions, besides issues and discussions in Github?

[timtebeek]

Sure, always welcome on our Slack! :)

[auke-]

An even smaller reproducer shows that the trailing comment is causing the issue:

import org.openrewrite.Foo;
interface Test {
  void foo() /* */;
}

[timtebeek]

Thanks for the helpful reproducer! Indeed something to fix in the parser then it seems. Did you already explore that side?

[auke-]

No, i didn't look into the parser side yet and i probably don't have time until after the weekend.