Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messaging/validation for faiss training #2268

Open
jmazanec15 opened this issue Nov 12, 2024 · 0 comments
Open

Improve error messaging/validation for faiss training #2268

jmazanec15 opened this issue Nov 12, 2024 · 0 comments
Assignees
Labels
Enhancements Increases software capabilities beyond original client specifications v2.19.0

Comments

@jmazanec15
Copy link
Member

Description

One consistent feedback we get around PQ and IVF is that there is limited visibility into the failure cases. Part of this is because the errors are thrown on the faiss side and we dont return stack traces in Rest response.

This makes it difficult to use PQ and IVF.

To make it better, we should explicitly detect and message the following cases:
[ ] For PQ, explicitly check in OpenSearch an invalid configuration where m does not divide dimension
[ ] For PQ/IVF, check the number of training points matches the minimum clustering criteria defined in faiss
[ ] If there is not enough memory, explicitly say that there is not enough memory.

Checking these 3 configurations will cover 90% of the training failures that occur. With the changes made in disk-based, it should be relatively easy to do this.

Related Issues

#1332
#593

@jmazanec15 jmazanec15 added the Enhancements Increases software capabilities beyond original client specifications label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancements Increases software capabilities beyond original client specifications v2.19.0
Projects
Status: Backlog
Development

No branches or pull requests

2 participants