Skip to content

Commit 4d575a5

Browse files
Merge pull request #455 from davidesalerno/ocpbugs65498
OCPBUGS-65498: Add openshift-dns-operator ClusterRole to ClusterOpera…
2 parents 6d768b5 + d08fbd6 commit 4d575a5

3 files changed

Lines changed: 29 additions & 0 deletions

File tree

manifests/0000_70_dns-operator_03-cluster-operator.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,3 +13,10 @@ status:
1313
versions:
1414
- name: operator
1515
version: "0.0.1-snapshot"
16+
relatedObjects:
17+
- group: rbac.authorization.k8s.io
18+
resource: clusterroles
19+
name: openshift-dns-operator
20+
- group: rbac.authorization.k8s.io
21+
name: dns-operator
22+
resource: clusterrolebindings

pkg/operator/controller/status/controller.go

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import (
77

88
"github.com/google/go-cmp/cmp"
99
"github.com/google/go-cmp/cmp/cmpopts"
10+
rbacv1 "k8s.io/api/rbac/v1"
1011

1112
configv1 "github.com/openshift/api/config/v1"
1213
operatorv1 "github.com/openshift/api/operator/v1"
@@ -136,6 +137,16 @@ func (r *reconciler) Reconcile(ctx context.Context, request reconcile.Request) (
136137
Resource: "dnses",
137138
Name: "default",
138139
},
140+
{
141+
Group: rbacv1.GroupName,
142+
Resource: "clusterroles",
143+
Name: "openshift-dns-operator",
144+
},
145+
{
146+
Group: rbacv1.GroupName,
147+
Resource: "clusterrolebindings",
148+
Name: "openshift-dns-operator",
149+
},
139150
}
140151
if state.haveNamespace {
141152
related = append(related, configv1.ObjectReference{

test/e2e/operator_test.go

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121

2222
appsv1 "k8s.io/api/apps/v1"
2323
corev1 "k8s.io/api/core/v1"
24+
rbacv1 "k8s.io/api/rbac/v1"
2425
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2526
"sigs.k8s.io/controller-runtime/pkg/client"
2627
ctrlruntimelog "sigs.k8s.io/controller-runtime/pkg/log"
@@ -123,6 +124,16 @@ func TestClusterOperatorStatusRelatedObjects(t *testing.T) {
123124
Resource: "dnses",
124125
Name: "default",
125126
},
127+
{
128+
Group: rbacv1.GroupName,
129+
Resource: "clusterroles",
130+
Name: "openshift-dns-operator",
131+
},
132+
{
133+
Group: rbacv1.GroupName,
134+
Resource: "clusterrolebindings",
135+
Name: "openshift-dns-operator",
136+
},
126137
{
127138
Resource: "namespaces",
128139
Name: "openshift-dns",

0 commit comments

Comments
 (0)