-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add font-awesome to front-end deps #5
Comments
👍 would close issue on checklist as well I suspect: opensourcedesign/foss-contributors-checklist#4. |
Yeh, even though not all of the icons are awesome it’s probably easiest. :) And it showcases a great open source design project. |
Why not using SVGs instead of iconfonts? We could use CC icons from nounproject https://thenounproject.com/ |
I must say I also prefer SVG. The only advantages are:
On top of that the style & quality of icons available on thenounproject is better. And I mean, how many do we need? |
Sorry, but – what are the icons meant to be used for? |
How much of a hassle is using SVGs versus including a link to font awesome's CDN? And updating the SVG file every time we add another one? (I'm hesitant to add another build step to this project that's meant to be accessible and easily maintainable). Also @jdittrich raises a good point. For the foss-contributors-checklist it's purely aesthetic, and that particular project might be better served by using nounproject SVGs. But as something to use across all of our sites that follows a standardized theme? |
I believe this can be closed. We're using FA on the site, currently. Reopen if I am mistaken. |
https://fortawesome.github.io/Font-Awesome/icons/ because, icons 😁
The text was updated successfully, but these errors were encountered: