Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add font-awesome to front-end deps #5

Closed
bnvk opened this issue Apr 26, 2015 · 7 comments
Closed

Add font-awesome to front-end deps #5

bnvk opened this issue Apr 26, 2015 · 7 comments

Comments

@bnvk
Copy link
Member

bnvk commented Apr 26, 2015

https://fortawesome.github.io/Font-Awesome/icons/ because, icons 😁

@simonv3
Copy link
Member

simonv3 commented Apr 26, 2015

👍 would close issue on checklist as well I suspect: opensourcedesign/foss-contributors-checklist#4.

@jancborchardt
Copy link
Member

Yeh, even though not all of the icons are awesome it’s probably easiest. :) And it showcases a great open source design project.

@Xaviju
Copy link
Member

Xaviju commented Apr 26, 2015

Why not using SVGs instead of iconfonts?
https://css-tricks.com/icon-fonts-vs-svg/

We could use CC icons from nounproject https://thenounproject.com/

@jancborchardt
Copy link
Member

I must say I also prefer SVG. The only advantages are:

  • really quick coloring – but we won’t really use color (also scratch that, SVG icons can be colored just the same & better, see above article)
  • only one file is loaded – which we can fix using https://github.com/jkphl/iconizr

On top of that the style & quality of icons available on thenounproject is better. And I mean, how many do we need?

@jdittrich
Copy link
Member

Sorry, but – what are the icons meant to be used for?

@simonv3
Copy link
Member

simonv3 commented Apr 26, 2015

How much of a hassle is using SVGs versus including a link to font awesome's CDN? And updating the SVG file every time we add another one? (I'm hesitant to add another build step to this project that's meant to be accessible and easily maintainable).

Also @jdittrich raises a good point. For the foss-contributors-checklist it's purely aesthetic, and that particular project might be better served by using nounproject SVGs. But as something to use across all of our sites that follows a standardized theme?

@RichardLitt
Copy link
Member

I believe this can be closed. We're using FA on the site, currently. Reopen if I am mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

6 participants