Skip to content

Commit 30c7462

Browse files
botovqdjmdjm
authored andcommitted
upstream: Remove redundant field of definition check
This will allow us to get rid of EC_GROUP_method_of() in the near future. ok djm OpenBSD-Commit-ID: b4a3d2e00990cf5c2ec6881c21ddca67327c2df8
1 parent eaa1744 commit 30c7462

File tree

1 file changed

+1
-14
lines changed

1 file changed

+1
-14
lines changed

sshkey.c

+1-14
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* $OpenBSD: sshkey.c,v 1.147 2024/09/22 12:56:21 jsg Exp $ */
1+
/* $OpenBSD: sshkey.c,v 1.148 2024/12/03 15:53:51 tb Exp $ */
22
/*
33
* Copyright (c) 2000, 2001 Markus Friedl. All rights reserved.
44
* Copyright (c) 2008 Alexander von Gernler. All rights reserved.
@@ -2705,14 +2705,6 @@ sshkey_ec_validate_public(const EC_GROUP *group, const EC_POINT *public)
27052705
* EC_POINT_oct2point then the caller will need to explicitly check.
27062706
*/
27072707

2708-
/*
2709-
* We shouldn't ever hit this case because bignum_get_ecpoint()
2710-
* refuses to load GF2m points.
2711-
*/
2712-
if (EC_METHOD_get_field_type(EC_GROUP_method_of(group)) !=
2713-
NID_X9_62_prime_field)
2714-
goto out;
2715-
27162708
/* Q != infinity */
27172709
if (EC_POINT_is_at_infinity(group, public))
27182710
goto out;
@@ -2812,11 +2804,6 @@ sshkey_dump_ec_point(const EC_GROUP *group, const EC_POINT *point)
28122804
fprintf(stderr, "%s: BN_new failed\n", __func__);
28132805
goto out;
28142806
}
2815-
if (EC_METHOD_get_field_type(EC_GROUP_method_of(group)) !=
2816-
NID_X9_62_prime_field) {
2817-
fprintf(stderr, "%s: group is not a prime field\n", __func__);
2818-
goto out;
2819-
}
28202807
if (EC_POINT_get_affine_coordinates_GFp(group, point,
28212808
x, y, NULL) != 1) {
28222809
fprintf(stderr, "%s: EC_POINT_get_affine_coordinates_GFp\n",

0 commit comments

Comments
 (0)