Skip to content

Commit ca591e4

Browse files
authored
CORE-1352: Intermittent test failures in Rex (mostly after PRs are merged) (#2589)
* fix variable null * run jira issue only in pull request
1 parent e4d4e70 commit ca591e4

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ jobs:
1010
linked_issue:
1111
name: Jira
1212
runs-on: ubuntu-latest
13+
if: github.event_name == 'pull_request'
1314
steps:
1415
- uses: openstax/[email protected]
1516
with:

src/app/content/components/Page.spec.tsx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1288,7 +1288,7 @@ describe('Page', () => {
12881288
state.navigation.hash = '#somehash';
12891289
archiveLoader.mockPage(book, someHashPage, 'unused3');
12901290

1291-
const {root} = renderDomWithReferences();
1291+
const {root} = renderDomWithReferences({ html: someHashPage.content });
12921292

12931293
let resolveImageLoaded: undefined | ((value?: void | PromiseLike<void> | undefined) => void);
12941294
const allImagesLoadedPromise = new Promise<void>((resolve) => {
@@ -1301,11 +1301,6 @@ describe('Page', () => {
13011301

13021302
(allImagesLoaded as any as jest.SpyInstance).mockReturnValue(allImagesLoadedPromise);
13031303

1304-
store.dispatch(actions.receivePage({
1305-
...someHashPage,
1306-
references: [],
1307-
}));
1308-
13091304
await new Promise((resolve) => setTimeout(resolve, 10));
13101305
// deferred scroll execution (scrollToTarget uses setImmediate)
13111306
await new Promise((resolve) => setImmediate(resolve));

0 commit comments

Comments
 (0)