From a75a6de8e227c42656a7f597ae322972f2461064 Mon Sep 17 00:00:00 2001 From: Josiah Ivey Date: Mon, 18 Aug 2025 14:08:10 -0700 Subject: [PATCH 1/2] update selected border styles --- src/components/Tabs.tsx | 1 + src/components/ToggleButtonGroup/styles.ts | 2 ++ .../__snapshots__/ButtonBar.spec.tsx.snap | 6 ++-- .../__snapshots__/Tabs.spec.tsx.snap | 6 ++-- .../ToggleButtonGroup.spec.tsx.snap | 30 +++++++++---------- 5 files changed, 24 insertions(+), 21 deletions(-) diff --git a/src/components/Tabs.tsx b/src/components/Tabs.tsx index 7a2a032d5..ba25617df 100644 --- a/src/components/Tabs.tsx +++ b/src/components/Tabs.tsx @@ -58,6 +58,7 @@ export const buttonBarItemCss = css` &[data-selected=true] { background: ${colors.palette.neutralLight}; + box-shadow: inset 0 0 0 0.1rem ${colors.palette.pale}; } &:hover:not([data-selected=true]) { background: ${colors.palette.neutralLighter}; diff --git a/src/components/ToggleButtonGroup/styles.ts b/src/components/ToggleButtonGroup/styles.ts index 2b8c3fde7..b52f823a4 100644 --- a/src/components/ToggleButtonGroup/styles.ts +++ b/src/components/ToggleButtonGroup/styles.ts @@ -25,6 +25,8 @@ export const StyledToggleButton = styled(ToggleButton)` &[data-selected] { background-color: ${colors.palette.neutralLighter}; + // achieve a 2px border effect without disrupting layout + box-shadow: inset 0 0 0 0.1rem ${colors.palette.pale}; } &[data-disabled] { diff --git a/src/components/__snapshots__/ButtonBar.spec.tsx.snap b/src/components/__snapshots__/ButtonBar.spec.tsx.snap index 970493657..ac3f4feda 100644 --- a/src/components/__snapshots__/ButtonBar.spec.tsx.snap +++ b/src/components/__snapshots__/ButtonBar.spec.tsx.snap @@ -3,7 +3,7 @@ exports[`ButtonBar renders 1`] = `
One @@ -18,7 +18,7 @@ exports[`ButtonBar renders 1`] = ` exports[`ButtonBar renders large size 1`] = `