Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The DAG for harmonisation and fine-mapping of UKBB-PPP #3493

Closed
2 of 3 tasks
addramir opened this issue Sep 19, 2024 · 5 comments · Fixed by opentargets/orchestration#39
Closed
2 of 3 tasks

The DAG for harmonisation and fine-mapping of UKBB-PPP #3493

addramir opened this issue Sep 19, 2024 · 5 comments · Fixed by opentargets/orchestration#39
Assignees
Labels
Genetics Relates to Open Targets genetics team

Comments

@addramir
Copy link

addramir commented Sep 19, 2024

The closest to finish DAG. Includes steps for harmonisation, locus breaker and collection.

@addramir addramir added Gentropy Genetics Relates to Open Targets genetics team labels Sep 19, 2024
@project-defiant
Copy link

project-defiant commented Sep 24, 2024

Linking current DAGs:

@addramir to clear it up from the DAG perspecive:

  • add LocusBreakerClumpingStep to the harmonisation dag
  • add qc step to inform which loci should be filtered out - this should create a loci manifesto like one in gs://genetics-portal-dev-analysis/dc16/output/ukb_ppp/clean_loci.parquet
  • merge finemapping dag to harmonisation
  • rename the harmonisation dag to ukb_ppp_eur_ingestion

@addramir
Copy link
Author

Not sure whether merge finemapping dag to harmonisation is a good idea. The data is hamronised and unlikly to be changed but we may want to rerun FM several times with diffrent parameters.

@project-defiant
Copy link

Even if the dags are merged, starting from the finemapping is just commenting the config.

@addramir
Copy link
Author

Ok, sounds good. Do you need any help here?

@project-defiant
Copy link

Just point me to the QC step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Genetics Relates to Open Targets genetics team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants