Skip to content

Conversation

@PT-10
Copy link

@PT-10 PT-10 commented Dec 7, 2025

Details

  • Implemented quantized::linear_relu based pimarily off quantized::linear.
  • Included pytest

Tickets

@PT-10 PT-10 requested a review from a team as a code owner December 7, 2025 09:39
@github-actions github-actions bot added the category: PyTorch FE OpenVINO PyTorch Frontend label Dec 7, 2025
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Dec 7, 2025
@PT-10
Copy link
Author

PT-10 commented Dec 7, 2025

@mvafin I've been facing certain issues while running the tests, this corresponds to the following section in ./src/bindings/python/src/openvino/frontend/pytorch/ts_decoder.py :

try:
                # these params exist only for conv params
                stride = pt_value.stride()
                padding = pt_value.padding()
                dilation = pt_value.dilation()
                groups = pt_value.groups()
                res += ivalue_to_constant(stride,
                                          shared_memory=self._shared_memory)
                res += ivalue_to_constant(padding,
                                          shared_memory=self._shared_memory)
                res += ivalue_to_constant(dilation,
                                          shared_memory=self._shared_memory)
                res += ivalue_to_constant(groups,
                                          shared_memory=self._shared_memory)
            except Exception as e:
                logging.debug("Failed to get conv params", exc_info=e)

the tests pass when I comment this out, however they fail when this exists. The issue arises due to the fact that LinearReLU return LinearPackedParams which do not have these params

@PT-10
Copy link
Author

PT-10 commented Dec 9, 2025

@mmikolajcz @PiotrKrzem requesting a review so that we can fix any bugs and move forward. Also having opened the issue in PyTorch, the quantized::<fn_name> seems to be deprecated, and have been moved to pt2e and torchao, let me know if we're to proceed similarly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: PyTorch FE OpenVINO PyTorch Frontend ExternalPR External contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Support quantized::linear_relu

2 participants