Remove the filtering of large courses on the course admin "Manage OTP Secrets" page.

This page loads quickly regardless of if these courses are filtered out.
Furthermore the menus are generally responsive even when these large
courses are included.  The only case where something is a bit slow is in
the case that on the "Copy Single Secret" tab the selected "Source
Course ID" is one of these large courses.  In that case if you click on
the "Source User ID" it takes some time for the dropdown menu to appear
and even then it has to be an astronomically large course for that to be
slow (more than 20,000 users).  However, even if the large courses are
included as long as a large course is not selected the menus are quick.

It is interesting that the multiple select elements on the "Copy
Multiple Secrets" tab are still fast even with astronomically large
courses.  It is just the single select elements on the "Copy Single
Secret" tab that experience a noticeable slowdown.

In any case, the point is that there is no reason to filter these
courses.  Doing so just adds unnecessary steps for the user.

Author: drgrice1

lib/WeBWorK/ContentGenerator/CourseAdmin.pm

@@ -2442,23 +2442,14 @@ sub do_save_lti_course_map ($c) {
 
 # Form to copy or reset OTP secrets.
 sub manage_otp_secrets_form ($c) {
-	my $courses          = {};
-	my $dbs              = {};
-	my $skipped_courses  = [];
-	my $show_all_courses = $c->param('show_all_courses') || 0;
+	my $courses = {};
+	my $dbs     = {};
 
 	# Create course data first, since it is used in all cases and initializes course db references.
 	for my $courseID (listCourses($c->ce)) {
 		my $ce = WeBWorK::CourseEnvironment->new({ courseName => $courseID });
-		$dbs->{$courseID} = WeBWorK::DB->new($ce->{dbLayouts}{ $ce->{dbLayoutName} });
-
-		# By default ignore courses larger than 200 users, as this can cause a large load building menus.
-		my @users = $dbs->{$courseID}->listUsers;
-		if ($show_all_courses || scalar @users < 200) {
-			$courses->{$courseID} = \@users;
-		} else {
-			push(@$skipped_courses, $courseID);
-		}
+		$dbs->{$courseID}     = WeBWorK::DB->new($ce->{dbLayouts}{ $ce->{dbLayoutName} });
+		$courses->{$courseID} = [ $dbs->{$courseID}->listUsers ];
 	}
 
 	# Process the confirmed rest or copy actions here.
@@ -2500,11 +2491,7 @@ sub manage_otp_secrets_form ($c) {
 		}
 	}
 
-	return $c->include(
-		'ContentGenerator/CourseAdmin/manage_otp_secrets_form',
-		courses         => $courses,
-		skipped_courses => $skipped_courses
-	);
+	return $c->include('ContentGenerator/CourseAdmin/manage_otp_secrets_form', courses => $courses);
 }
 
 # Deals with both single and multiple copy confirmation.

templates/ContentGenerator/CourseAdmin/copy_otp_secrets_confirm.html.ep

@@ -40,7 +40,7 @@
 			</tbody>
 		</table>
 	</div>
-	<%= $c->hidden_fields('subDisplay', 'show_all_courses') =%>
+	<%= $c->hidden_fields('subDisplay') =%>
 	% if ($total > 0) {
 		% my $skipped = @$action_rows - $total;
 		<%= content 'hidden-rows' %>

templates/ContentGenerator/CourseAdmin/manage_otp_secrets_form.html.ep

@@ -8,17 +8,6 @@
 %
 <h2><%= maketext('Manage OTP Secrets') %> <%= $c->helpMacro('AdminManageOTPSecrets') %></h2>
 <%= form_for current_route, method => 'POST', begin =%>
-	% if (@$skipped_courses) {
-		<div class="mb-3">
-			<div class="alert alert-warning mb-2">
-				<%= maketext('The following large courses are not shown: [_1]', join(', ', @$skipped_courses)); =%>
-			</div>
-			<p>
-				<%= submit_button maketext('Show All Courses'),
-					name => 'show_all_courses', class => 'btn btn-primary' =%>
-			</p>
-		</div>
-	% }
 	<div>
 		<ul class="nav nav-tabs mb-2" role="tablist">
 			% for my $tab ('single', 'multiple', 'reset') {
@@ -147,7 +136,7 @@
 									disabled                     => undef,
 									selected                     => undef,
 								],
-								sort (@course_keys, @$skipped_courses)
+								sort @course_keys
 							],
 							id       => 'destMultipleCourseID',
 							class    => 'form-select',
@@ -195,7 +184,7 @@
 			</div>
 		</div>
 	</div>
-	<%= $c->hidden_fields('subDisplay', 'show_all_courses') =%>
+	<%= $c->hidden_fields('subDisplay') =%>
 	<%= hidden_field action => $active_tab, id => 'current_action' =%>
 	<div class="mb-3">
 		<%= submit_button $active_tab eq 'single'

templates/ContentGenerator/CourseAdmin/reset_otp_secrets_confirm.html.ep

@@ -28,7 +28,7 @@
 			</tbody>
 		</table>
 	</div>
-	<%= $c->hidden_fields('subDisplay', 'show_all_courses', 'sourceResetCourseID') =%>
+	<%= $c->hidden_fields('subDisplay', 'sourceResetCourseID') =%>
 	% if ($total > 0) {
 		% my $skipped = @$action_rows - $total;
 		<%= content 'hidden-rows' %>

templates/HelpFiles/AdminManageOTPSecrets.html.ep

@@ -34,8 +34,3 @@
 	<%= maketext('If resetting secrets, choose a source course ID, then choose one (or more) users whose secrets '
 		. 'will be reset. Note, the user(s) will have to setup two factor authentication afterwards.') =%>
 </p>
-<p class="mb-0">
-	<%= maketext('By default, courses larger than 200 users will not be shown, as this can cause extra CPU usage '
-		. 'when generating the user menus.  If any large course is skipped, a message will inform you of which '
-		. 'courses were skipped, and a button to show all courses can be used to include those courses.') =%>
-</p>