New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gn check doesn't work for jumbo files #2

Open

bratell-at-opera opened this issue Mar 1, 2019 · 1 comment

Contributor

bratell-at-opera commented Mar 1, 2019

command_check.cc follows includes but not well enough so it will not find includes done through jumbified files.

Contributor Author

bratell-at-opera commented Mar 1, 2019

I think there are two possible problems that have to be solved.

I think the header checker (header_checker.cc) might only be looking at files ending with a .h.
The checker will only complain about files listed in sources (that is why it's important to also list all headers in sources), and that might prevent it from following dependencies through jumbo files since they are no longer in sources (or are they?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment