Skip to content

Commit 939446b

Browse files
authored
fix constant reconcilation issue in helm controller (#6892)
Signed-off-by: Adam D. Cornett <[email protected]>
1 parent a96ec5c commit 939446b

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

internal/helm/controller/reconcile.go

+6-1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import (
1818
"context"
1919
"errors"
2020
"fmt"
21+
"reflect"
2122
"strconv"
2223
"strings"
2324
"time"
@@ -104,6 +105,7 @@ func (r HelmOperatorReconciler) Reconcile(ctx context.Context, request reconcile
104105
}
105106

106107
status := types.StatusFor(o)
108+
originalStatus := o.DeepCopy().Object["status"]
107109
log = log.WithValues("release", manager.ReleaseName())
108110

109111
reconcileResult := reconcile.Result{RequeueAfter: r.ReconcilePeriod}
@@ -421,7 +423,10 @@ func (r HelmOperatorReconciler) Reconcile(ctx context.Context, request reconcile
421423
Manifest: expectedRelease.Manifest,
422424
}
423425

424-
err = r.updateResourceStatus(ctx, o, status)
426+
if !reflect.DeepEqual(status, originalStatus) {
427+
err = r.updateResourceStatus(ctx, o, status)
428+
}
429+
425430
return reconcileResult, err
426431
}
427432

0 commit comments

Comments
 (0)