Skip to content

Commit 374fa79

Browse files
authored
🐛 fix(imcp): Remove auto-register condition and update comments (#9)
- Remove conditional auto-registration logic and simplify tool registration - Add clarifying comments about MCP client tool registration 🔧 chore(mcpclient): Deprecate autoRegister parameter and update comments - Mark autoRegister parameter as deprecated for backward compatibility - Add note about automatic tool registration for successfully registered MCP servers
1 parent e9eafb6 commit 374fa79

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

internal/imcp/external.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,8 @@ func (s *MCPServer) RegisterExternalMCPTools(ctx context.Context, manager *mcpcl
2020

2121
// 遍历所有外部 MCP 客户端
2222
for _, mcpClient := range manager.List() {
23-
if !mcpClient.Config.AutoRegister {
24-
logx.Info("⏭️ Skip auto-register for MCP: %s", mcpClient.Config.Name)
25-
continue
26-
}
27-
23+
// 只要 MCP 客户端已加载到 Manager 中,就注册其工具
24+
// 注意:Manager.LoadFromConfig 已经过滤了未启用的服务器
2825
registeredCount := 0
2926
failedCount := 0
3027

internal/mcpclient/manager.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,6 +330,7 @@ func (m *Manager) CloseAll() {
330330
}
331331

332332
// RegisterFromDB 从数据库模型注册 MCP 客户端
333+
// 注意: autoRegister 参数已废弃,现在只要 MCP 服务器被成功注册,其工具就会被自动注册
333334
func (m *Manager) RegisterFromDB(name string, serverType string, command string, args []string, env map[string]string, baseURL string, headers map[string]string, timeout int, toolPrefix string, autoRegister bool) error {
334335
// 创建配置
335336
cfg := &config.MCPServerConfig{
@@ -342,7 +343,7 @@ func (m *Manager) RegisterFromDB(name string, serverType string, command string,
342343
Timeout: timeout,
343344
IsActive: true,
344345
ToolPrefix: toolPrefix,
345-
AutoRegister: autoRegister,
346+
AutoRegister: autoRegister, // 已废弃,保留仅为向后兼容
346347
}
347348

348349
return m.Register(name, cfg)

0 commit comments

Comments
 (0)