Added Some Delays in Process and Browser Kills

I added some short delays when killing processes, in particular
browsers, in the hope to achieve more graceful termination. This way,
I hope to get rid of errors like

https://ci.appveyor.com/project/thomasWeise/evaluator-gui/build/job/29kly0oct9akryno

Author: thomasWeise

src/main/java/org/optimizationBenchmarking/utils/tools/impl/browser/BrowserJob.java

@@ -23,6 +23,9 @@ public final class BrowserJob extends ToolJob implements Closeable {
    */
   private final boolean m_isWaitForReliable;
 
+  /** the time when the browser started */
+  private final long m_startupTime;
+
   /**
    * Create the browser job,
    *
@@ -49,6 +52,7 @@ public final class BrowserJob extends ToolJob implements Closeable {
     this.m_process = process;
     this.m_temp = temp;
     this.m_isWaitForReliable = isWaitForReliable;
+    this.m_startupTime = System.currentTimeMillis();
   }
 
   /**
@@ -95,6 +99,7 @@ public final boolean isWaitForReliable() {
   /** {@inheritDoc} */
   @Override
   public final void close() throws IOException {
+    final long wait;
     ExternalProcess proc;
     TempDir temp;
 
@@ -107,11 +112,32 @@ public final void close() throws IOException {
 
     try {
       if (proc != null) {
-        proc.close();
+        try {
+          // we give the browser 3s to start up before we close it
+          wait = ((3000L - System.currentTimeMillis())
+              + this.m_startupTime);
+          if (wait > 0L) {
+            Thread.sleep(wait);
+          }
+        } catch (@SuppressWarnings("unused") final Throwable error) {
+          // ignore
+        } finally {
+          try {
+            proc.close();
+          } finally {
+            proc = null;
+          }
+        }
       }
     } finally {
       if (temp != null) {
-        temp.close();
+        try {
+          Thread.sleep(100L);
+        } catch (@SuppressWarnings("unused") final Throwable error) {
+          // ignore
+        } finally {
+          temp.close();
+        }
       }
     }
   }

src/main/java/org/optimizationBenchmarking/utils/tools/impl/process/ExternalProcess.java

@@ -181,8 +181,21 @@ private final int __close(final boolean kill) throws IOException {
           }
 
           if (shouldKill) {
-            this.m_process.destroy();
             shouldMessage = true;
+            try {
+              // wait a bit in a last-ditch effort to let the process
+              // gracefully terminate
+              Thread.sleep(20L);
+            } catch (final InterruptedException ie) {
+              // ingore
+            }
+            this.m_process.destroy();
+            try {
+              // wait a bit in an effort to let destroy() work
+              Thread.sleep(20L);
+            } catch (final InterruptedException ie) {
+              // ingore
+            }
           }
         } catch (final Throwable t) {
           error = ErrorUtils.aggregateError(t, error);