test: finish coverage

Author: mikechu-optimizely

OptimizelySDK.Tests/OptimizelyUserContextTest.cs

@@ -61,6 +61,22 @@ public void SetUp()
                 LoggerMock.Object, ErrorHandlerMock.Object);
         }
 
+        private Mock<UserProfileService> makeUserProfileServiceMock()
+        {
+            var projectConfig = DatafileProjectConfig.Create(TestData.Datafile, LoggerMock.Object,
+                ErrorHandlerMock.Object);
+            var experiment = projectConfig.Experiments[8];
+            var variation = experiment.Variations[0];
+            var decision = new Decision(variation.Id);
+            var userProfile = new UserProfile(UserID, new Dictionary<string, Decision>
+            {
+                { experiment.Id, decision },
+            });
+            var userProfileServiceMock = new Mock<UserProfileService>();
+            userProfileServiceMock.Setup(up => up.Lookup(UserID)).Returns(userProfile.ToMap());
+            return userProfileServiceMock;
+        }
+
         [Test]
         public void OptimizelyUserContextWithAttributes()
         {
@@ -407,18 +423,25 @@ public void DecideWhenConfigIsNull()
 
             Assert.IsTrue(TestData.CompareObjects(decision, decisionExpected));
         }
-        
+
         [Test]
         public void DecideWithUspShouldOnlyLookupSaveOnce()
         {
             var flagKeyFromTestDataJson = "double_single_variable_feature";
-            var userProfileServiceMock = new Mock<UserProfileService>();
+            var userProfileServiceMock = makeUserProfileServiceMock();
             var optimizely = new Optimizely(TestData.Datafile, EventDispatcherMock.Object,
                 LoggerMock.Object, ErrorHandlerMock.Object, userProfileServiceMock.Object);
             var user = optimizely.CreateUserContext(UserID);
-            
+
             _ = user.Decide(flagKeyFromTestDataJson);
-            
+
+            LoggerMock.Verify(
+                l => l.Log(LogLevel.INFO,
+                    "We were unable to get a user profile map from the UserProfileService."),
+                Times.Never);
+            LoggerMock.Verify(
+                l => l.Log(LogLevel.ERROR, "The UserProfileService returned an invalid map."),
+                Times.Never);
             userProfileServiceMock.Verify(l => l.Lookup(UserID), Times.Once);
             userProfileServiceMock.Verify(l => l.Save(It.IsAny<Dictionary<string, object>>()),
                 Times.Once);
@@ -431,19 +454,26 @@ public void DecideWithUspShouldOnlyLookupSaveOnce()
         [Test]
         public void DecideForKeysWithUspShouldOnlyLookupSaveOnceWithMultipleFlags()
         {
-            var flagKeys = new [] { "double_single_variable_feature", "boolean_feature" };
-            var userProfileServiceMock = new Mock<UserProfileService>();
+            var flagKeys = new[] { "double_single_variable_feature", "boolean_feature" };
+            var userProfileServiceMock = makeUserProfileServiceMock();
             var optimizely = new Optimizely(TestData.Datafile, EventDispatcherMock.Object,
                 LoggerMock.Object, ErrorHandlerMock.Object, userProfileServiceMock.Object);
             var userContext = optimizely.CreateUserContext(UserID);
-            
+
             _ = userContext.DecideForKeys(flagKeys);
-            
+
+            LoggerMock.Verify(
+                l => l.Log(LogLevel.INFO,
+                    "We were unable to get a user profile map from the UserProfileService."),
+                Times.Never);
+            LoggerMock.Verify(
+                l => l.Log(LogLevel.ERROR, "The UserProfileService returned an invalid map."),
+                Times.Never);
             userProfileServiceMock.Verify(l => l.Lookup(UserID), Times.Once);
             userProfileServiceMock.Verify(l => l.Save(It.IsAny<Dictionary<string, object>>()),
                 Times.Once);
         }
-        
+
         [Test]
         public void DecideForKeysWithOneFlag()
         {
@@ -473,21 +503,28 @@ public void DecideForKeysWithOneFlag()
                 new string[0]);
             Assert.IsTrue(TestData.CompareObjects(decision, expDecision));
         }
-        
+
         #endregion DecideForKeys
-        
+
         #region DecideAll
-        
+
         [Test]
         public void DecideAllWithUspShouldOnlyLookupSaveOnce()
         {
-            var userProfileServiceMock = new Mock<UserProfileService>();
+            var userProfileServiceMock = makeUserProfileServiceMock();
             var optimizely = new Optimizely(TestData.Datafile, EventDispatcherMock.Object,
                 LoggerMock.Object, ErrorHandlerMock.Object, userProfileServiceMock.Object);
             var user = optimizely.CreateUserContext(UserID);
-            
+
             _ = user.DecideAll();
-            
+
+            LoggerMock.Verify(
+                l => l.Log(LogLevel.INFO,
+                    "We were unable to get a user profile map from the UserProfileService."),
+                Times.Never);
+            LoggerMock.Verify(
+                l => l.Log(LogLevel.ERROR, "The UserProfileService returned an invalid map."),
+                Times.Never);
             userProfileServiceMock.Verify(l => l.Lookup(UserID), Times.Once);
             userProfileServiceMock.Verify(l => l.Save(It.IsAny<Dictionary<string, object>>()),
                 Times.Once);

OptimizelySDK/Bucketing/DecisionService.cs

@@ -45,7 +45,7 @@ public class DecisionService
         private ILogger Logger;
         private UserProfile _userProfile;
 
-        private bool _decisionBatchInProgress = false;
+        private bool _decisionBatchInProgress;
 
         public bool DecisionBatchInProgress
         {