add support for stateless rules #1044
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Contributor
|
Can you please elaborate why:
|
Member
Author
|
|
+1 on the value of this. We've had a few situations working with customers where they used the TF modules and then had to redo the NSGs to make them stateless due to running into performance issues. |
hyder
reviewed
Dec 5, 2025
| ) : {} | ||
| ) | ||
|
|
||
| bastion_stateless_rules = merge( |
Contributor
There was a problem hiding this comment.
Bastion and operator are used for admin/troubleshooting purposes. I don't see the need to make their rules stateless.
hyder
reviewed
Dec 5, 2025
| protocol = local.icmpv6_protocol, source = local.worker_nsg_id, source_type = local.rule_type_nsg, | ||
| }, | ||
| } : {}, | ||
| local.operator_nsg_enabled ? { |
Contributor
There was a problem hiding this comment.
as above, operator is for troubleshooting. do we really need this rule to be stateless? maybe for the bastion and operator, just create them separately?
hyder
reviewed
Dec 5, 2025
Contributor
hyder
left a comment
hyder
left a comment
There was a problem hiding this comment.
Let me know what you think about the bastion and operator rules for stateless and then I'll test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to create NSGs with stateless rules.