Fix file perms

Author: tmiddlet2666

.github/workflows/build-monitoring.yaml

@@ -51,11 +51,7 @@ jobs:
           export PATH=`pwd`/bin:$PATH
           cohctl init monitoring -y
           cohctl start monitoring 
-          sleep 30
-          for container in `docker ps -a | sed 1d | awk '{print $1}'`; do
-             docker logs $container
-          done
-          docker ps
+          sleep 15
           netstat -an | grep 9090
           netstat -an | grep 3000
           cohctl get monitoring

pkg/cmd/monitoring.go

@@ -420,15 +420,16 @@ func monitoringNotValid(message string) error {
 func writeFileContents(base, file string, content []byte) error {
 	destPath := filepath.Join(base, file)
 
-	if err := os.WriteFile(destPath, content, 0600); err != nil {
+	// #nosec G306 -- file is meant to be readable by docker on Linux
+	if err := os.WriteFile(destPath, content, 0644); err != nil {
 		return fmt.Errorf("error writing file %s: %w", destPath, err)
 	}
 
 	return nil
 }
 
 func ensureDirectory(directory string) error {
-	err := utils.EnsureDirectory(directory)
+	err := utils.EnsureDirectoryWithPerms(directory, 0755)
 	if err != nil {
 		return fmt.Errorf("unable to create directory: %s, %v", directory, err)
 	}

pkg/utils/utils.go

@@ -17,6 +17,7 @@ import (
 	"github.com/oracle/coherence-cli/pkg/constants"
 	"go.uber.org/zap"
 	"go.uber.org/zap/zapcore"
+	"io/fs"
 	"os"
 	"path/filepath"
 	"regexp"
@@ -149,9 +150,14 @@ func GetJSONPathResults(jsonData []byte, jsonPath string) (string, error) {
 
 // EnsureDirectory ensures a directory exists and if not then will create it.
 func EnsureDirectory(directory string) error {
+	return EnsureDirectoryWithPerms(directory, 0700)
+}
+
+// EnsureDirectoryWithPerms ensures a directory exists and if not then will create it with specific permissions.
+func EnsureDirectoryWithPerms(directory string, perm fs.FileMode) error {
 	if _, err := os.Stat(directory); err != nil {
 		if os.IsNotExist(err) {
-			err = os.Mkdir(directory, 0700)
+			err = os.Mkdir(directory, perm)
 			if err != nil {
 				return GetError("unable to create directory "+directory, err)
 			}