Invalid login session with Github OAuth

[tito]

Hi,

I have a self-hosted version of Fief (0.26.0), with the default Fief workspace and multiple Tenant.
I configured Github OAuth as described, and activated for a specific tenant.

From my Next JS app, i see the following process:

1. https://myapp.com/login (provided by fief-js) -> returns HTTP 307
2. https://fief.myapp.com/mytenant/authorize?response_type=code&... -> returns HTTP 302
3. https://fief.myapp.com/mytenant/login -> returns HTTP 200
4. I click on the github button
5. https://fief.myapp.com/oauth/authorize?tenant=xxxxxxx&provider=xxxxxxx -> returns HTTP 302
6. https://github.com/login/oauth/authorize?response_type=code&client_id=xxxx&redirect_uri=https%3A%2F%2Ffief.myapp.com%2Foauth%2Fcallback&state=xxxx&scope=offline_access+openid+user+user%3Aemail -> returns HTTP 302
7. https://fief.myapp.com/oauth/callback?code=xxxx&state=xxxx -> returns HTTP 400

With the error "Invalid login session"

What did i do wrong ?

[frankie567]

Hmm, that's indeed a bug due to the multiple tenants setup.

The server tries to match the login session with the current tenant, which is desirable in most cases. However, since /oauth/callback doesn't add the tenant prefix (for convenience, so we do not have to add a redirect URI for every tenant), it should be a bit more clever than that.

I'll make a fix ASAP. Thank you for reporting!

[frankie567]

Followed in #256