Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for prompt=select_account during settings OIDC link #268

Closed
3 of 5 tasks
jonas-jonas opened this issue Nov 8, 2024 · 5 comments
Closed
3 of 5 tasks

Comments

@jonas-jonas
Copy link
Member

Preflight checklist

Ory Network Project

No response

Describe your problem

When linking OIDC account, it is common that users have multiple Google accounts signed in at once. Depending on what they chose before, Google might choose to skip account selection and consent, making it very difficult to choose the right account to link during settings OIDC linking.

Describe your ideal solution

Kratos already supports upstream_parameters, and thus prompt, and we should just force the select_account prompt for Google (and possibly others, though it's not clear, what the side effects of this are

Workarounds or alternatives

Version

master

Additional Context

No response

@jonas-jonas
Copy link
Member Author

Fixed via #266

@aeneasr
Copy link
Member

aeneasr commented Jan 28, 2025

Shouldn't this be solved in kratos instead? Otherwise it only works for elements but not native and other sdks

@aeneasr
Copy link
Member

aeneasr commented Jan 28, 2025

Generally I think flow logic shouldn't belong in Ory Elements, otherwise it will be quite challenging to have consistent use experiences across different sdks (versions and clients).

@jonas-jonas
Copy link
Member Author

Yea I was thinking that we could add an option to the Oidc provider config to configure these parameters by default. I think that would make most sense. I'll work on that.

@aeneasr
Copy link
Member

aeneasr commented Jan 28, 2025

That might be already possible. I'm also OK to show account selection for account linking only. If you always pass account_select it will cause issues when double redirecting, see: ory/kratos#4064

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants