Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login and recovery flows end up with hard to i18n error if identity is disabled #4164

Open
5 tasks done
splaunov opened this issue Oct 21, 2024 · 0 comments
Open
5 tasks done
Labels
feat New feature or request.

Comments

@splaunov
Copy link
Contributor

Preflight checklist

Ory Network Project

No response

Describe your problem

When login or recovery flow comes to a point where new session should be activated but identity happens to be inactive, then ErrIdentityDisabled is created. This error type does not contain an error ID which would allow native or web client to process it and to display the error message in the user's language.

Describe your ideal solution

I would suggest converting ErrIdentityDisabled error into schema.ValidationError which contains messages with ID.

Workarounds or alternatives

Base message localisation not on ID but on message text matching.

Version

1.2

Additional Context

No response

@splaunov splaunov added the feat New feature or request. label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request.
Projects
None yet
Development

No branches or pull requests

1 participant