Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privileged session login still looks like "unified" login flow if code is enabled #4194

Open
3 of 5 tasks
jonas-jonas opened this issue Nov 6, 2024 · 1 comment
Open
3 of 5 tasks
Labels
bug Something is not working.

Comments

@jonas-jonas
Copy link
Member

Preflight checklist

Ory Network Project

No response

Describe the bug

The privileged login screen looks like the unified login flow if both password + code are enabled.

image

Reproducing the bug

  1. configure code for passwordless
  2. configure password
  3. go to settings page
  4. wait for the privileged session to expired
  5. try to change the password
  6. see the screen

Relevant log output

No response

Relevant configuration

No response

Version

master

On which operating system are you observing this issue?

None

In which environment are you deploying?

None

Additional Context

No response

@jonas-jonas jonas-jonas added the bug Something is not working. label Nov 6, 2024
@jonas-jonas
Copy link
Member Author

I believe the issue is, that the PopulateMethod method of the code login doesn't distinguish between refresh and normal logins. It should just add a hidden form field for the identifier of the current session on refresh logins. That way, the UI can just show a "send code" field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

No branches or pull requests

1 participant