Yarn2+ still misses dependencies

[oheger-bosch]

This is a follow-up to #8058. We have tested the fix applied for this issue on multiple customer projects. The outcome is that it has improved the results from the Yarn2+ analysis significantly; however, compared to the results reported for Yarn classic, there are still dependencies that are not found.

Here are some concrete numbers:

• In one project, the number of dependencies reported for Yarn2+ went up from 499 to 636, while Yarn classics finds 1028.
• For another project, the number of Yarn2+ dependencies went up from 109 to 493, while Yarn classics finds 685.

I hope that we will be able to provide more details about which packages are missing later.

[myklosbotond]

From my AI-assisted analysis of our project, the gap seems to come from the transitive dependencies of non-scoped packages.

We now see that scoped dependencies that have peerDependencies declared, like @react-native-community/netinfo, have their transitive dependencies correctly listed in the tree view. Non-scoped ones, however, like react-native-worklets or typia (both of which have peerDependencies), show up as only leaf nodes, without any subtrees under them.

The cause seems to be the regex introduced under #11208: Regex("""^(@[^@]+)@.*#npm:([0-9]+\.[0-9]+\.[0-9]+)"""), which expects the presence of two @ characters in the name.

Possibly """^(@?[^@]+)@.*#npm:([0-9]+\.[0-9]+\.[0-9]+)""" could fix this bug.

[sschuberth]

Here are some concrete numbers:

Just as a theory to keep in mind: Could it also be that Yarn classic was over-reporting? How confident are you that the Yarn classic numbers are correct and can server as a "gold standard"?

[oheger-bosch]

Over-reporting in Yarn classic may be an option, but I think it is reasonable to assume that a package like react-native should at least have some dependencies. I have run a test scan with the proposed fix (see #11847), and now the number of detected dependencies in that project is rather close to what Yarn classic reported: 517 (Yarn2+) vs 579.