Define slidehow behavior

[lsd-cat]

When should we force the user to do the slideshow and enable adb? I see two cases:

• The users has no saved scan yet
• The users has done scans, but want to do a new one

So, there's a case where the user maybe has revoked permissions, but they should be able to consult the past scans. If they want to do scans again, they should run through the slideshow and complete the missing steps.

[TheZ3ro]

Putting my rationale in writings:

IMHO the slideshow has the main goal of explaining "how bugbane works" so the users that are new to bugbane should see the slideshow while the other probably have most of the requirements already (they are trained, they are experts or they used it already) so do not want to bother with the slideshow (most notably the welcome screen and get ready).

This to say: if it is not the first time the user runs bugbane they probably want to reach the main screen immediately (either to perform a scan or to share a dump).
From there, if all the permissions are granted we can already do a scan, otherwise we show only show the relevant slideshow pages.

WDYT? Any feedback?

[rocodes]

I agree with both of you, and just want to confirm a detail that came up in #37 :

Right now in #37, you only have to see the info/consent pages once. So if you open the app for the first time, see the Welcome page, and click "I understand", you won't see the welcome page again even if you don't complete onboarding (ie, you'll pick up exactly where you left off -- so if you proceed until the wifi screen, then close the app, then reopen it, you go directly to the Wifi settings page with no preamble).

There's also the alternative option of showing the Welcome screen every time until the full onboarding has been completed (so it would be "I understand" -> then skip to whatever remaining permissions/configuration is needed). I didn't implement that, but if people like it better, I can.

[rocodes]

I thought of one more slideshow question:

Right now, suppose a user completes the slideshow and does an acquisition, then disables developer options. Then they decide to scan again and click "enable permissions" (restart the permissions slideshow), but change their mind. There's currently no off-ramp/cancellation option - they have to go through the permissions flow.

We might want to provide an off-ramp when the user already has existing acquisitions, because otherwise a user can't even get back to the acquisitions screen to see/export them, because the SlideshowActivity overrides onBackPressed and just quits the app (good for first onboarding, maybe not desirable for subsequent permissions runs).

[lsd-cat]

Didn't think about that and it makes perfect sense. Do we want to add maybe an X on the top right, or a "Go to acquisitions" link, if there's already at least one?

[TheZ3ro]

Nice catch!
I think that putting a "Go to my acquisitions" button if there is at least one would be the preferable option
(more user friendly than a X or a "onBackPressed")