Skip to content

Conversation

@Draal
Copy link

@Draal Draal commented Nov 13, 2025

Checklist

  • I have read the contribution guidelines.
  • make test passes.
  • make lint passes.
  • New and changed code is covered by tests.
  • Performance improvements include benchmarks.
  • Changes match the documented (not just the implemented) behavior of Shopify.

Draal and others added 30 commits May 15, 2020 11:06
Fix `{{ people.custom.company | default: 'there' }}` variables
fix decimal filter default value not working
Empty bool && missing leading zero month / day date format
introduce thousand delimiter for decimal by default
HenryHK and others added 29 commits March 17, 2025 13:41
only log phone info if it's not nil and failed to convert
improve nil value comparison if nil values involved
use same var for code consistency
remove include tag to prevent filesystem access
add protection and debug log on VariableBind cast error case
Var can be nil if it's assigned value
@osteele
Copy link
Owner

osteele commented Nov 15, 2025

Thank you for your interest in contributing to this project!

However, I'm unable to merge this PR as it appears to be a fork divergence rather than a focused contribution. Here are the main concerns:

Issues

  1. Fork-specific changes: This PR changes all repository URLs from osteele/liquid to autopilot3/liquid across 64 files. These URL changes would break all links in the documentation and point users to a different repository.

  2. Out of scope: This project's goal is compatibility with Shopify Liquid. The PR adds many custom filters and features that are not part of Shopify Liquid:

    • Custom cryptographic filters (md5, sha1, sha256, hmac variants)
    • Proprietary phone number formatting filters
    • CRM-specific functionality (activity IDs, display types, custom tags)
    • Custom set operations (setContains, setContainsAll)

    These belong in application code as extensions (see osteele/gojekyll for an example), or in a fork, not in this library.

  3. Massive scope: With 2,522 additions across 64 files and 90+ commits, this mixes too many unrelated changes to review effectively.

  4. Incomplete submission: The checklist in the PR description is empty, and many commits reference "WIP" or linting fixes.

What would be acceptable

Contributions that would be welcome:

  • Bug fixes for Shopify Liquid compatibility
  • Missing Shopify Liquid features or filters
  • Performance improvements
  • Better error messages

Custom filters should be added by users of the library, not included in the core library.

I recommend closing this PR. If you need these custom features, please maintain them in your fork (autopilot3/liquid).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants