-
Notifications
You must be signed in to change notification settings - Fork 68
Add adv currency formatting #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add ability to find variables
Fix `{{ people.custom.company | default: 'there' }}` variables
new filter for subject
add phone default support
custom tags
fix bad naming
fix multiplier for decimal/currency
fix decimal filter default value not working
Empty bool && missing leading zero month / day date format
introduce thousand delimiter for decimal by default
only log phone info if it's not nil and failed to convert
improve nil value comparison if nil values involved
add startsWith/endsWith
fix slice of interface cast
add check for divider
use same var for code consistency
remove include tag to prevent filesystem access
add protection and debug log on VariableBind cast error case
Pass context to logs
Var can be nil if it's assigned value
Fix using assigned vars in loops
|
Thank you for your interest in contributing to this project! However, I'm unable to merge this PR as it appears to be a fork divergence rather than a focused contribution. Here are the main concerns: Issues
What would be acceptableContributions that would be welcome:
Custom filters should be added by users of the library, not included in the core library. I recommend closing this PR. If you need these custom features, please maintain them in your fork (autopilot3/liquid). |
Checklist
make testpasses.make lintpasses.