Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use buffered output in list command #702

Closed
marcospb19 opened this issue Aug 26, 2024 · 0 comments · Fixed by #764
Closed

use buffered output in list command #702

marcospb19 opened this issue Aug 26, 2024 · 0 comments · Fixed by #764
Labels
enhancement New feature or request

Comments

@marcospb19
Copy link
Member

ouch/src/list.rs

Line 35 in b2d0ff7

let out = &mut stdout().lock();

All output to this file should be done with BufWriter.

(On top of that, writeln! shouldn't be mixed with print!, we should only use the former.)
@marcospb19 marcospb19 added the enhancement New feature or request label Aug 26, 2024
@marcospb19 marcospb19 changed the title Use BufWriter in list command output use buffered output in list command Aug 26, 2024
killercup added a commit to killercup/ouch that referenced this issue Feb 12, 2025
@killercup
fix: Use BufWriter for list output
3101b31 
Also replaces one `print` call with `write`.

Fixes ouch-org#702
killercup added a commit to killercup/ouch that referenced this issue Feb 12, 2025
@killercup
fix: Use BufWriter for list output
4c1e3fe 
Also replaces one `print` call with `write`.

Fixes ouch-org#702
@killercup killercup mentioned this issue Feb 12, 2025
Merged
killercup added a commit to killercup/ouch that referenced this issue Feb 12, 2025
@killercup
fix: Use BufWriter for list output
346bc09 
Also replaces one `print` call with `write`.

Fixes ouch-org#702
marcospb19 pushed a commit that referenced this issue Feb 12, 2025
@killercup @marcospb19
fix: Use BufWriter for list output
aeefa69 
Also replaces one `print` call with `write`.

Fixes #702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use BufWriter for list output killercup/ouch
1 participant
@marcospb19