-
-
Notifications
You must be signed in to change notification settings - Fork 642
Improve UI scaling for 4k displays #747
base: master
Are you sure you want to change the base?
Conversation
|
Thank you so much for the PR! I'll give it a proper review over the weekend. |
|
@LukeWasTakenn a question regarding the GitHub Actions pipelines. I tried running a build using the Node and pnpm versions you're currently using to build ox_lib. These currently fail because I updated the lockfile using a more up to date version of pnpm (v10). I can make another PR to update the release scripting to Node 22 + pnpm 10, but that might mean you also need to upgrade the server version requirement to build |
|
Let's avoid bumping the node version, for now at least. Though you should still be able to use pnpm 10, should build fine after it generates an updated lock file...? |
|
The latest version of pnpm that's compatible with Node v16 is pnpm v8. I did some extra digging and it seems to be related to one of the patches which are run when installing dependencies: I've also tried running this on the master branch and it throws the same error. |
|
@LukeWasTakenn did you manage to test this PR? |
|
no, the state of the project is up in the air right now. |
|
Ah okay 😅, I'll leave this as is for now. Should you need any more assistance with maintaining Overextended, feel free to reach out on Discord (lord_chunk) |
Signed-off-by: Job <[email protected]>
Signed-off-by: Job <[email protected]>
Converted all pixel units to rem. Also added logic in main.css for scaling the root font size for higher resolution displays.
Fixes: #669