Skip to content

Let's make tutor-indigo and tutor-contrib-branding compatible #145

@angonz

Description

@angonz

The objective of tutor-contrib-branding is to make small or medium size, incremental changes to a base theme. It works fine starting from the default open-edx theme.

However we need to disable tutor-indigo in order to make tutor-contrib-branding plugin work. The reason is that both touch same files in the container images.

We would like to make tutor-indigo compatible with tutor-contrib-branding, so we can use Indigo as a base theme and make changes on top of it.

A small example:
If you enable both plugins you will have this result in the MFE Dockerfile:

 1: RUN mkdir /openedx/brand-openedx
 2: COPY ./brand-openedx /openedx/brand-openedx
 3: 
 4: RUN npm install '@edx/brand@file:/openedx/brand-openedx'
 5: 
 6: ENV CPPFLAGS=-DPNG_ARM_NEON_OPT=0
 7: ENV PACT_SKIP_BINARY_INSTALL=true
 8: RUN --mount=type=cache,target=/root/.npm,sharing=shared npm clean-install --no-audit --no-fund --registry=$NPM_REGISTRY
 9: 
10: RUN npm install '@edx/brand@npm:@edly-io/indigo-brand-openedx@^2.2.2'

Lines 1-4 are added by tutor-contrib-branding, which installs @edx/brand from a local file.
Line 8 install the MFE
Line 10 is added by Indigo, overwriting the branding package.

Metadata

Metadata

Labels

enhancementNew feature or request

Type

No type

Projects

Status

Backlog

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions