fix(mrc): move array excluded columns in constant file

ref: #MANAGER-17732

Signed-off-by: Guillaume Hyenne <guillaume.hyenne@ovhcloud.com>

Author: ghyenne

packages/manager-react-components/src/components/datagrid/datagrid-topbar.component.tsx

@@ -16,8 +16,10 @@ import { FilterWithLabel } from '../filters/interface';
 import { FilterAdd, FilterList } from '../filters';
 import { ColumnFilter } from '../filters/filter-add.component';
 import './translations';
-import { VisibilityManagement } from './visibility/visibility-management.component';
-import { ColumnsVisibility } from './datagrid.constants';
+import {
+  ColumnsVisibility,
+  VisibilityManagement,
+} from './visibility/visibility-management.component';
 
 type ColumnFilterProps = {
   key: string;

packages/manager-react-components/src/components/datagrid/datagrid.constants.ts

@@ -10,15 +10,4 @@ export const DEFAULT_PAGINATION: PaginationState = {
 
 export const defaultNumberOfLoadingRows = 5;
 
-export type ColumnsVisibility = {
-  id: string;
-  isDisabled: boolean;
-  label: string;
-  enableHiding: boolean;
-  isVisible: () => boolean;
-  onChange: () => void;
-};
-
-export type ColumnsVisibilityProps = {
-  columnsVisibility: ColumnsVisibility[];
-};
+export const INTERNAL_COLUMNS = ['expander', 'actions'];

packages/manager-react-components/src/components/datagrid/visibility/visibility-management.component.tsx

@@ -13,19 +13,31 @@ import {
 } from '@ovhcloud/ods-components/react';
 import { useRef } from 'react';
 import { useTranslation } from 'react-i18next';
-import { ColumnsVisibilityProps } from '../datagrid.constants';
+import { INTERNAL_COLUMNS } from '../datagrid.constants';
+
+export type ColumnsVisibility = {
+  id: string;
+  isDisabled: boolean;
+  label: string;
+  enableHiding: boolean;
+  isVisible: () => boolean;
+  onChange: () => void;
+};
+
+export type ColumnsVisibilityProps = {
+  columnsVisibility: ColumnsVisibility[];
+};
 
 export function VisibilityManagement({
   columnsVisibility,
 }: Readonly<ColumnsVisibilityProps>) {
   const { t } = useTranslation('datagrid');
   const visibilityPopoverRef = useRef(null);
-  const columnsIncludedInCounter = columnsVisibility.filter(
-    (column) =>
-      !['expander', 'actions'].includes(column.id) && column.label !== '',
+  const eligibleColumns = columnsVisibility.filter(
+    (column) => !INTERNAL_COLUMNS.includes(column.id) && column.label !== '',
   );
 
-  const visibleColumnsCount = columnsIncludedInCounter.filter((column) =>
+  const visibleColumnsCount = eligibleColumns.filter((column) =>
     column.isVisible(),
   ).length;
 
@@ -40,7 +52,7 @@ export function VisibilityManagement({
         icon={ODS_ICON_NAME.columns}
         aria-label={t('common_topbar_columns')}
         label={`${t('common_topbar_columns')}${
-          visibleColumnsCount < columnsIncludedInCounter.length
+          visibleColumnsCount < eligibleColumns.length
             ? ` (${visibleColumnsCount})`
             : ''
         }`}
@@ -51,7 +63,7 @@ export function VisibilityManagement({
         with-arrow
       >
         <div className="flex flex-col">
-          {columnsIncludedInCounter.map((column) => (
+          {eligibleColumns.map((column) => (
             <OdsFormField key={column.id}>
               <div className="flex flex-row items-center gap-x-2">
                 <OdsCheckbox