[lldb][test] Remove full stop from expected error messages (llvm#193748)

I am about to update a bunch of uses of AppendErrorWithFormat to not
have a full stop at the end, to confirm to
https://llvm.org/docs/CodingStandards.html#error-and-warning-messages.

Reviewing all those changes is going to be difficult so I am updating
the tests first and then we can land the other changes in batches
(because the tests will continue to pass as we do that).

Note that I have only run the test suite on Linux AArch64, so there are
probably more that need to be updated. We will catch those in CI or
post-commit.

Author: DavidSpickett

lldb/test/API/commands/breakpoint/command/list/TestBreakpointCommandList.py

@@ -52,5 +52,5 @@ def test_list_commands(self):
         self.expect(
             "breakpoint command list 2",
             error=True,
-            startstr="error: '2' is not a currently valid breakpoint ID.",
+            startstr="error: '2' is not a currently valid breakpoint ID",
         )

lldb/test/API/commands/command/container/TestContainerCommands.py

@@ -237,7 +237,7 @@ def container_add(self):
         self.expect(
             "test-multi test-multi-sub welcome friend",
             "did remove subcommand",
-            substrs=["'test-multi-sub' does not have any subcommands."],
+            substrs=["'test-multi-sub' does not have any subcommands"],
             error=True,
         )
         # We should have the new help:
@@ -262,6 +262,6 @@ def container_add(self):
         self.expect(
             "test-multi",
             "Root command gone",
-            substrs=["'test-multi' is not a valid command."],
+            substrs=["'test-multi' is not a valid command"],
             error=True,
         )

lldb/test/API/commands/command/delete/TestCommandDelete.py

@@ -10,7 +10,7 @@ def test_delete_builtin(self):
             "command delete settings",
             error=True,
             substrs=[
-                "'settings' is a permanent debugger command and cannot be removed."
+                "'settings' is a permanent debugger command and cannot be removed"
             ],
         )
 

lldb/test/API/commands/command/invalid-args/TestInvalidArgsCommand.py

@@ -54,7 +54,7 @@ def test_alias(self):
             "command alias blub foo",
             error=True,
             substrs=[
-                "error: invalid command given to 'command alias'. 'foo' does not begin with a valid command.  No alias created."
+                "error: invalid command given to 'command alias'. 'foo' does not begin with a valid command.  No alias created"
             ],
         )
 
@@ -87,7 +87,5 @@ def test_source(self):
         self.expect(
             "command source",
             error=True,
-            substrs=[
-                "'command source' takes exactly one executable filename argument."
-            ],
+            substrs=["'command source' takes exactly one executable filename argument"],
         )

lldb/test/API/commands/expression/dont_allow_jit/TestAllowJIT.py

@@ -91,7 +91,7 @@ def test_allow_jit_with_top_level(self):
         self.expect(
             "expr --allow-jit false --top-level -- int i;",
             error=True,
-            substrs=["Can't disable JIT compilation for top-level expressions."],
+            substrs=["Can't disable JIT compilation for top-level expressions"],
         )
 
         self.build()

lldb/test/API/commands/frame/recognizer/TestFrameRecognizer.py

@@ -73,12 +73,12 @@ def test_frame_recognizer_1(self):
         self.expect(
             "frame recognizer delete 2",
             error=True,
-            substrs=["error: '2' is not a valid recognizer id."],
+            substrs=["error: '2' is not a valid recognizer id"],
         )
         self.expect(
             "frame recognizer delete 0",
             error=True,
-            substrs=["error: '0' is not a valid recognizer id."],
+            substrs=["error: '0' is not a valid recognizer id"],
         )
         # Recognizers should have the same state as above.
         self.expect(
@@ -448,45 +448,45 @@ def test_frame_recognizer_delete_invalid_arg(self):
         self.expect(
             "frame recognizer delete a",
             error=True,
-            substrs=["error: 'a' is not a valid recognizer id."],
+            substrs=["error: 'a' is not a valid recognizer id"],
         )
         self.expect(
             'frame recognizer delete ""',
             error=True,
-            substrs=["error: '' is not a valid recognizer id."],
+            substrs=["error: '' is not a valid recognizer id"],
         )
         self.expect(
             "frame recognizer delete -1",
             error=True,
-            substrs=["error: '-1' is not a valid recognizer id."],
+            substrs=["error: '-1' is not a valid recognizer id"],
         )
         self.expect(
             "frame recognizer delete 4294967297",
             error=True,
-            substrs=["error: '4294967297' is not a valid recognizer id."],
+            substrs=["error: '4294967297' is not a valid recognizer id"],
         )
 
     @no_debug_info_test
     def test_frame_recognizer_info_invalid_arg(self):
         self.expect(
             "frame recognizer info a",
             error=True,
-            substrs=["error: 'a' is not a valid frame index."],
+            substrs=["error: 'a' is not a valid frame index"],
         )
         self.expect(
             'frame recognizer info ""',
             error=True,
-            substrs=["error: '' is not a valid frame index."],
+            substrs=["error: '' is not a valid frame index"],
         )
         self.expect(
             "frame recognizer info -1",
             error=True,
-            substrs=["error: '-1' is not a valid frame index."],
+            substrs=["error: '-1' is not a valid frame index"],
         )
         self.expect(
             "frame recognizer info 4294967297",
             error=True,
-            substrs=["error: '4294967297' is not a valid frame index."],
+            substrs=["error: '4294967297' is not a valid frame index"],
         )
 
     @no_debug_info_test

lldb/test/API/commands/log/invalid-args/TestInvalidArgsLog.py

@@ -9,9 +9,7 @@ def test_enable_empty(self):
         self.expect(
             "log enable",
             error=True,
-            substrs=[
-                "error: log enable takes a log channel and one or more log types."
-            ],
+            substrs=["error: log enable takes a log channel and one or more log types"],
         )
 
     @no_debug_info_test
@@ -20,7 +18,7 @@ def test_disable_empty(self):
             "log disable",
             error=True,
             substrs=[
-                "error: log disable takes a log channel and one or more log types."
+                "error: log disable takes a log channel and one or more log types"
             ],
         )
 

lldb/test/API/commands/process/signal/TestProcessSignal.py

@@ -15,15 +15,15 @@ def test_invalid_arg(self):
         self.expect(
             "process signal az",
             error=True,
-            startstr="error: Invalid signal argument 'az'.",
+            startstr="error: Invalid signal argument 'az'",
         )
         self.expect(
             "process signal 0x1ffffffff",
             error=True,
-            startstr="error: Invalid signal argument '0x1ffffffff'.",
+            startstr="error: Invalid signal argument '0x1ffffffff'",
         )
         self.expect(
             "process signal 0xffffffff",
             error=True,
-            startstr="error: Invalid signal argument '0xffffffff'.",
+            startstr="error: Invalid signal argument '0xffffffff'",
         )

lldb/test/API/commands/register/register_command/TestRegisters.py

@@ -579,7 +579,7 @@ def test_write_unknown_register(self):
         self.expect(
             "register write blub 1",
             error=True,
-            substrs=["error: Register not found for 'blub'."],
+            substrs=["error: Register not found for 'blub'"],
         )
 
     def test_info_unknown_register(self):
@@ -589,7 +589,7 @@ def test_info_unknown_register(self):
         self.expect(
             "register info blub",
             error=True,
-            substrs=["error: No register found with name 'blub'."],
+            substrs=["error: No register found with name 'blub'"],
         )
 
     def test_info_many_registers(self):

lldb/test/API/commands/target/modules/search-paths/insert/TestTargetModulesSearchpathsInsert.py

@@ -14,11 +14,11 @@ def test_invalid_arg(self):
         self.expect(
             "target modules search-paths insert -1 a b",
             error=True,
-            startstr="error: <index> parameter is not an integer: '-1'.",
+            startstr="error: <index> parameter is not an integer: '-1'",
         )
 
         self.expect(
             "target modules search-paths insert abcdefx a b",
             error=True,
-            startstr="error: <index> parameter is not an integer: 'abcdefx'.",
+            startstr="error: <index> parameter is not an integer: 'abcdefx'",
         )