[feature/new-issue-view] New Issue view / presentation (#874)

* Add support for TLS certificate change diff:
- ConnectionIssueViewController:
	- compare against certificate stored in the bookmark where available
	- remove text-based rendering via CertificateViewController (and remove the class), replace it with the standard certificate view controller
- adaptions to new ThemeCertificateViewController initialization where needed
- update SDK

* - update sdk

* - Issues presentation
	- remove IssuesViewController, ConnectionIssueViewController, IssuesPresentationAnimator and IssuesDismissalAnimator
	- create modern replacement leveraging existing code: IssuesCardViewController
	- migrate code from ConnectionIssueViewController to IssuesCardViewController
	- add new helper function to compare DisplayIssues issue levels without having to use .rawValue
- MoreViewController
	- becomes FrameViewController
	- adds the ability to also add a footer view
	- cleanup: removal of unused properties and initializers
- StaticTableViewRow: add .messageStyle support
- ThemeTableViewCell: add .messageStyle support and add additional CellStyler block API based on also new CellStyleSet
- AlertView:
	- add support for .accessibilityIdentifier
	- add option for custom .contentPadding
	- add button-only mode
- CardPresentationController:
	- ensure .dismissable is actually respected
	- fix premature release of CardTransitionDelegate that could lead to normal presentation rather than as a card

* - add missing licensing comment

* - update SDK

* Address finding 1 in #874 and fix missing fill color in the safe area:
- FrameViewController: include table background color pin theming support
- ThemeTableViewCell:
	- support recreation of labels and custom layout of these labels
	- add primaryTextLabel and primaryDetailTextLabel accessors to access text labels irrespective of whether they are system-provided or recreated
- StaticTableViewRow
	- add support for recreated labels and their custom layout
- IssuesCardViewController
	- replace usage of constraints in CardCellBackgroundView with auto resized views (fixes auto layout constraint warnings)
	- switch to using primaryTextLabel and primaryDetailTextLabel and a custom recreatedLabelLayout

Co-authored-by: Matthias Hühne <github@hosy.de>

Author: felix-schwarz

ownCloud.xcodeproj/project.pbxproj

@@ -422,10 +422,12 @@ class BookmarkViewController: StaticTableViewController {
 
 							if issue != nil {
 								// Parse issue for display
-								if let displayIssues = issue?.prepareForDisplay() {
-									if displayIssues.displayLevel.rawValue >= OCIssueLevel.warning.rawValue {
+								if let issue = issue {
+									let displayIssues = issue.prepareForDisplay()
+
+									if displayIssues.isAtLeast(level: .warning) {
 										// Present issues if the level is >= warning
-										let issuesViewController = ConnectionIssueViewController(displayIssues: displayIssues, completion: { [weak self] (response) in
+										IssuesCardViewController.present(on: self, issue: issue, displayIssues: displayIssues, completion: { [weak self, weak issue] (response) in
 											switch response {
 												case .cancel:
 													issue?.reject()
@@ -439,11 +441,9 @@ class BookmarkViewController: StaticTableViewController {
 													self?.bookmark?.url = nil
 											}
 										})
-
-										self.present(issuesViewController, animated: true, completion: nil)
 									} else {
 										// Do not present issues
-										issue?.approve()
+										issue.approve()
 										continueToNextStep()
 									}
 								}
@@ -503,8 +503,8 @@ class BookmarkViewController: StaticTableViewController {
 							self.updateInputFocus(fallbackRow: self.passwordRow)
 						} else if nsError?.isOCError(withCode: .authorizationCancelled) == true {
 							// User cancelled authorization, no reaction needed
-						} else {
-							let issuesViewController = ConnectionIssueViewController(displayIssues: issue?.prepareForDisplay(), completion: { [weak self] (response) in
+						} else if let issue = issue {
+							IssuesCardViewController.present(on: self, issue: issue, completion: { [weak self, weak issue] (response) in
 								switch response {
 									case .cancel:
 										issue?.reject()
@@ -516,8 +516,6 @@ class BookmarkViewController: StaticTableViewController {
 									case .dismiss: break
 								}
 							})
-
-							self.present(issuesViewController, animated: true, completion: nil)
 						}
 					})
 				}
@@ -598,10 +596,10 @@ class BookmarkViewController: StaticTableViewController {
 					} else {
 						OnMainThread {
 							hudCompletion({
-								if issue != nil {
+								if let issue = issue {
 									self?.bookmark?.authenticationData = nil
 
-									let issuesViewController = ConnectionIssueViewController(displayIssues: issue?.prepareForDisplay(), completion: { [weak self] (response) in
+									IssuesCardViewController.present(on: strongSelf, issue: issue, completion: { [weak self, weak issue] (response) in
 										switch response {
 											case .cancel:
 												issue?.reject()
@@ -613,8 +611,6 @@ class BookmarkViewController: StaticTableViewController {
 											case .dismiss: break
 										}
 									})
-
-									strongSelf.present(issuesViewController, animated: true, completion: nil)
 								} else {
 									strongSelf.presentingViewController?.dismiss(animated: true, completion: nil)
 								}