comment on why we're removing headers

david-crespo · david-crespo · commit 03a1d0f525cf · 2025-10-28T09:19:08.000-05:00
diff --git a/dropshot/src/compression.rs b/dropshot/src/compression.rs
@@ -235,6 +235,8 @@ pub fn apply_gzip_compression(response: Response<Body>) -> Response<Body> {
         );
     }
 
+    // because we're streaming, we can't handle ranges and we don't know the
+    // length of the response ahead of time
     parts.headers.remove(http::header::ACCEPT_RANGES);
     parts.headers.remove(http::header::CONTENT_LENGTH);
 

Original file line number	Diff line number	Diff line change
`@@ -235,6 +235,8 @@ pub fn apply_gzip_compression(response: Response<Body>) -> Response<Body> {`
`235`	`235`	`);`
`236`	`236`	`}`
`237`	`237`
	`238`	`+ // because we're streaming, we can't handle ranges and we don't know the`
	`239`	`+ // length of the response ahead of time`
`238`	`240`	`parts.headers.remove(http::header::ACCEPT_RANGES);`
`239`	`241`	`parts.headers.remove(http::header::CONTENT_LENGTH);`
`240`	`242`