Skip to content

Conversation

@scotus-1
Copy link

This allows for an explicitly defined version of LWJGL in the [versions] section of pack.toml. My reasoning for this is I distributed my modpack through multimc and shipped it with LWJGL version 3.3.3, in later updates of Sodium, this crashes.

low key this took me 6 hours to add two lines because i had to find the cmd line option to disable packwiz updating to test my local build but this works

@scotus-1
Copy link
Author

#31 (comment)

This mentions that MultiMC automatically sets the correct LWJGL version, on game version change, if people who don't better like me change LWJGL, it uh kinda breaks yk

@dalbitresb12
Copy link

#31 (comment)

This mentions that MultiMC automatically sets the correct LWJGL version, on game version change, if people who don't better like me change LWJGL, it uh kinda breaks yk

I've distributed my modpack as a Prism Launcher (MultiMC fork) importable profile, which I shipped with Minecraft 1.20.1 and LWJGL 3.3.1. Now that I'm upgrading to 1.21.1 through packwiz, the LWJGL versions stays at 3.3.1 instead of using the suggested one which is 3.3.3. It seems like the way that packwiz is modifying the mmc-pack.json file, Prism doesn't detect the game version change and it is not updating the LWJGL version, leaving the profile in a "warning" state (screenshot below).

image

One solution is this PR, which allows modpack creators to explicitly set the LWJGL version. Another possible solution is taking a similar approach as for the Fabric Intermediary Mappings: if the Minecraft version is changed by packwiz, then remove that component and MultiMC will just re-add the correct version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants