Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Great theme - some suggestions #123

Open
nickpoison opened this issue Oct 19, 2022 · 0 comments
Open

Great theme - some suggestions #123

nickpoison opened this issue Oct 19, 2022 · 0 comments

Comments

@nickpoison
Copy link

nickpoison commented Oct 19, 2022

This is a great theme and I have only 2 suggestions. (I'm editing this to get everything in one comment.)

  • First, and I think this applies to all supported themes, is there is no support for math. For those interested, in _layouts/default.html, I added the following after {% include head-custom.html %}:
<script>
MathJax = {
  tex: {
    inlineMath: [['$', '$'], ['\\(', '\\)']]
  },
  svg: {
    fontCache: 'global'
  }
};
</script>
<script type="text/javascript" id="MathJax-script" async
  src="https://cdn.jsdelivr.net/npm/mathjax@3/es5/tex-svg.js">
</script>

<link href='https://fonts.googleapis.com/css?family=Inconsolata' rel='stylesheet'>

This works fine, but I'm not sure why something like this isn't incorporated in these themes. The 'link' is for using google fonts... see the next item.

  • Second, text font should not be mono. It makes reading text difficult, and it started giving me a headache. I added _assets_css/style.scss as follows. The first changes the 'p' tag to be sans-serif and the second changes the 'code' tag to be "Inconsolata", which is a google font.
---
---

@import "{{ site.theme }}";
 p  *
{
   font-family: Verdana, Arial, sans-serif !important;
}

code *
{
   font-family: 'Inconsolata', Monaco, "Bitstream Vera Sans Mono", "Lucida Console", Terminal, monospace !important;
}

It's so much easier to read the text now.

Thanks for a great theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant