diff --git a/build.gradle b/build.gradle index 7e594e5..0cf2022 100644 --- a/build.gradle +++ b/build.gradle @@ -14,6 +14,7 @@ buildscript { classpath 'com.palantir.javaformat:gradle-palantir-java-format:2.89.0' classpath 'com.palantir.suppressible-error-prone:gradle-suppressible-error-prone:2.31.0' classpath 'com.diffplug.spotless:spotless-plugin-gradle:8.1.0' + classpath 'com.palantir.baseline-error-prone:gradle-baseline-error-prone:0.13.0' } } @@ -32,6 +33,7 @@ apply plugin: 'com.palantir.baseline' //this enables all plugins including check apply plugin: 'com.palantir.baseline-checkstyle' apply plugin: 'com.palantir.baseline-config' apply plugin: 'com.palantir.baseline-error-prone' +apply plugin: 'com.palantir.baseline-error-prone-root' apply plugin: 'com.palantir.baseline-idea' apply plugin: 'com.palantir.failure-reports' apply plugin: 'com.palantir.baseline-java-versions' diff --git a/gradle/exception b/gradle/exception new file mode 100644 index 0000000..8bbdfff --- /dev/null +++ b/gradle/exception @@ -0,0 +1,183 @@ + +* What went wrong: +Execution failed for task ':spotlessJava'. +> Couldn't list copyright directory: /repo/.baseline/copyright + +* Try: +> Run with --info or --debug option to get more log output. +> Run with --scan to get full insights. +> Get more help at https://help.gradle.org. + +* Exception is: +org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':spotlessJava'. + at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:130) + at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:293) + at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:128) + at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:116) + at org.gradle.api.internal.tasks.execution.ProblemsTaskPathTrackingTaskExecuter.execute(ProblemsTaskPathTrackingTaskExecuter.java:41) + at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46) + at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:51) + at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57) + at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:74) + at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36) + at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77) + at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55) + at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52) + at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:210) + at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:205) + at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:67) + at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:60) + at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:167) + at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:60) + at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:54) + at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter.execute(EventFiringTaskExecuter.java:52) + at org.gradle.execution.plan.LocalTaskNodeExecutor.execute(LocalTaskNodeExecutor.java:42) + at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:331) + at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:318) + at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.lambda$execute$0(DefaultTaskExecutionGraph.java:314) + at org.gradle.internal.operations.CurrentBuildOperationRef.with(CurrentBuildOperationRef.java:85) + at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:314) + at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:303) + at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.execute(DefaultPlanExecutor.java:459) + at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.run(DefaultPlanExecutor.java:376) + at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64) + at org.gradle.internal.concurrent.AbstractManagedExecutor$1.run(AbstractManagedExecutor.java:48) +Caused by: java.io.UncheckedIOException: Couldn't list copyright directory: /repo/.baseline/copyright + at com.palantir.baseline.plugins.BaselineFormat.computeCopyrightHeaders(BaselineFormat.java:156) + at com.palantir.baseline.plugins.BaselineFormat.lambda$createLazyLicenseHeaderStep$0(BaselineFormat.java:129) + at com.google.common.base.Suppliers$MemoizingSupplier.get(Suppliers.java:147) + at com.palantir.baseline.plugins.LazyFormatterStep.close(LazyFormatterStep.java:63) + at com.diffplug.spotless.Formatter.close(Formatter.java:228) + at com.diffplug.gradle.spotless.SpotlessTaskImpl.performAction(SpotlessTaskImpl.java:123) + at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) + at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:125) + at org.gradle.api.internal.project.taskfactory.IncrementalTaskAction.doExecute(IncrementalTaskAction.java:45) + at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:51) + at org.gradle.api.internal.project.taskfactory.IncrementalTaskAction.execute(IncrementalTaskAction.java:26) + at org.gradle.api.internal.project.taskfactory.StandardTaskAction.execute(StandardTaskAction.java:29) + at org.gradle.api.internal.tasks.execution.TaskExecution$3.run(TaskExecution.java:244) + at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:30) + at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:27) + at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:67) + at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:60) + at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:167) + at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:60) + at org.gradle.internal.operations.DefaultBuildOperationRunner.run(DefaultBuildOperationRunner.java:48) + at org.gradle.api.internal.tasks.execution.TaskExecution.executeAction(TaskExecution.java:229) + at org.gradle.api.internal.tasks.execution.TaskExecution.executeActions(TaskExecution.java:212) + at org.gradle.api.internal.tasks.execution.TaskExecution.executeWithPreviousOutputFiles(TaskExecution.java:195) + at org.gradle.api.internal.tasks.execution.TaskExecution.execute(TaskExecution.java:162) + at org.gradle.internal.execution.steps.ExecuteStep.executeInternal(ExecuteStep.java:105) + at org.gradle.internal.execution.steps.ExecuteStep.access$000(ExecuteStep.java:44) + at org.gradle.internal.execution.steps.ExecuteStep$1.call(ExecuteStep.java:59) + at org.gradle.internal.execution.steps.ExecuteStep$1.call(ExecuteStep.java:56) + at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:210) + at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:205) + at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:67) + at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:60) + at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:167) + at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:60) + at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:54) + at org.gradle.internal.execution.steps.ExecuteStep.execute(ExecuteStep.java:56) + at org.gradle.internal.execution.steps.ExecuteStep.execute(ExecuteStep.java:44) + at org.gradle.internal.execution.steps.CancelExecutionStep.execute(CancelExecutionStep.java:42) + at org.gradle.internal.execution.steps.TimeoutStep.executeWithoutTimeout(TimeoutStep.java:75) + at org.gradle.internal.execution.steps.TimeoutStep.execute(TimeoutStep.java:55) + at org.gradle.internal.execution.steps.PreCreateOutputParentsStep.execute(PreCreateOutputParentsStep.java:50) + at org.gradle.internal.execution.steps.PreCreateOutputParentsStep.execute(PreCreateOutputParentsStep.java:28) + at org.gradle.internal.execution.steps.RemovePreviousOutputsStep.execute(RemovePreviousOutputsStep.java:67) + at org.gradle.internal.execution.steps.RemovePreviousOutputsStep.execute(RemovePreviousOutputsStep.java:37) + at org.gradle.internal.execution.steps.BroadcastChangingOutputsStep.execute(BroadcastChangingOutputsStep.java:61) + at org.gradle.internal.execution.steps.BroadcastChangingOutputsStep.execute(BroadcastChangingOutputsStep.java:26) + at org.gradle.internal.execution.steps.CaptureOutputsAfterExecutionStep.execute(CaptureOutputsAfterExecutionStep.java:69) + at org.gradle.internal.execution.steps.CaptureOutputsAfterExecutionStep.execute(CaptureOutputsAfterExecutionStep.java:46) + at org.gradle.internal.execution.steps.ResolveInputChangesStep.execute(ResolveInputChangesStep.java:40) + at org.gradle.internal.execution.steps.ResolveInputChangesStep.execute(ResolveInputChangesStep.java:29) + at org.gradle.internal.execution.steps.BuildCacheStep.executeWithoutCache(BuildCacheStep.java:189) + at org.gradle.internal.execution.steps.BuildCacheStep.executeAndStoreInCache(BuildCacheStep.java:145) + at org.gradle.internal.execution.steps.BuildCacheStep.lambda$executeWithCache$4(BuildCacheStep.java:101) + at org.gradle.internal.execution.steps.BuildCacheStep.lambda$executeWithCache$5(BuildCacheStep.java:101) + at org.gradle.internal.Try$Success.map(Try.java:175) + at org.gradle.internal.execution.steps.BuildCacheStep.executeWithCache(BuildCacheStep.java:85) + at org.gradle.internal.execution.steps.BuildCacheStep.lambda$execute$0(BuildCacheStep.java:74) + at org.gradle.internal.Either$Left.fold(Either.java:115) + at org.gradle.internal.execution.caching.CachingState.fold(CachingState.java:62) + at org.gradle.internal.execution.steps.BuildCacheStep.execute(BuildCacheStep.java:73) + at org.gradle.internal.execution.steps.BuildCacheStep.execute(BuildCacheStep.java:48) + at org.gradle.internal.execution.steps.StoreExecutionStateStep.execute(StoreExecutionStateStep.java:46) + at org.gradle.internal.execution.steps.StoreExecutionStateStep.execute(StoreExecutionStateStep.java:35) + at org.gradle.internal.execution.steps.SkipUpToDateStep.executeBecause(SkipUpToDateStep.java:75) + at org.gradle.internal.execution.steps.SkipUpToDateStep.lambda$execute$2(SkipUpToDateStep.java:53) + at org.gradle.internal.execution.steps.SkipUpToDateStep.execute(SkipUpToDateStep.java:53) + at org.gradle.internal.execution.steps.SkipUpToDateStep.execute(SkipUpToDateStep.java:35) + at org.gradle.internal.execution.steps.legacy.MarkSnapshottingInputsFinishedStep.execute(MarkSnapshottingInputsFinishedStep.java:37) + at org.gradle.internal.execution.steps.legacy.MarkSnapshottingInputsFinishedStep.execute(MarkSnapshottingInputsFinishedStep.java:27) + at org.gradle.internal.execution.steps.ResolveIncrementalCachingStateStep.executeDelegate(ResolveIncrementalCachingStateStep.java:49) + at org.gradle.internal.execution.steps.ResolveIncrementalCachingStateStep.executeDelegate(ResolveIncrementalCachingStateStep.java:27) + at org.gradle.internal.execution.steps.AbstractResolveCachingStateStep.execute(AbstractResolveCachingStateStep.java:71) + at org.gradle.internal.execution.steps.AbstractResolveCachingStateStep.execute(AbstractResolveCachingStateStep.java:39) + at org.gradle.internal.execution.steps.ResolveChangesStep.execute(ResolveChangesStep.java:65) + at org.gradle.internal.execution.steps.ResolveChangesStep.execute(ResolveChangesStep.java:36) + at org.gradle.internal.execution.steps.ValidateStep.execute(ValidateStep.java:107) + at org.gradle.internal.execution.steps.ValidateStep.execute(ValidateStep.java:56) + at org.gradle.internal.execution.steps.AbstractCaptureStateBeforeExecutionStep.execute(AbstractCaptureStateBeforeExecutionStep.java:64) + at org.gradle.internal.execution.steps.AbstractCaptureStateBeforeExecutionStep.execute(AbstractCaptureStateBeforeExecutionStep.java:43) + at org.gradle.internal.execution.steps.AbstractSkipEmptyWorkStep.executeWithNonEmptySources(AbstractSkipEmptyWorkStep.java:125) + at org.gradle.internal.execution.steps.AbstractSkipEmptyWorkStep.execute(AbstractSkipEmptyWorkStep.java:56) + at org.gradle.internal.execution.steps.AbstractSkipEmptyWorkStep.execute(AbstractSkipEmptyWorkStep.java:36) + at org.gradle.internal.execution.steps.legacy.MarkSnapshottingInputsStartedStep.execute(MarkSnapshottingInputsStartedStep.java:38) + at org.gradle.internal.execution.steps.LoadPreviousExecutionStateStep.execute(LoadPreviousExecutionStateStep.java:36) + at org.gradle.internal.execution.steps.LoadPreviousExecutionStateStep.execute(LoadPreviousExecutionStateStep.java:23) + at org.gradle.internal.execution.steps.HandleStaleOutputsStep.execute(HandleStaleOutputsStep.java:75) + at org.gradle.internal.execution.steps.HandleStaleOutputsStep.execute(HandleStaleOutputsStep.java:41) + at org.gradle.internal.execution.steps.AssignMutableWorkspaceStep.lambda$execute$0(AssignMutableWorkspaceStep.java:35) + at org.gradle.api.internal.tasks.execution.TaskExecution$4.withWorkspace(TaskExecution.java:289) + at org.gradle.internal.execution.steps.AssignMutableWorkspaceStep.execute(AssignMutableWorkspaceStep.java:31) + at org.gradle.internal.execution.steps.AssignMutableWorkspaceStep.execute(AssignMutableWorkspaceStep.java:22) + at org.gradle.internal.execution.steps.ChoosePipelineStep.execute(ChoosePipelineStep.java:40) + at org.gradle.internal.execution.steps.ChoosePipelineStep.execute(ChoosePipelineStep.java:23) + at org.gradle.internal.execution.steps.ExecuteWorkBuildOperationFiringStep.lambda$execute$2(ExecuteWorkBuildOperationFiringStep.java:67) + at org.gradle.internal.execution.steps.ExecuteWorkBuildOperationFiringStep.execute(ExecuteWorkBuildOperationFiringStep.java:67) + at org.gradle.internal.execution.steps.ExecuteWorkBuildOperationFiringStep.execute(ExecuteWorkBuildOperationFiringStep.java:39) + at org.gradle.internal.execution.steps.IdentityCacheStep.execute(IdentityCacheStep.java:46) + at org.gradle.internal.execution.steps.IdentityCacheStep.execute(IdentityCacheStep.java:34) + at org.gradle.internal.execution.steps.IdentifyStep.execute(IdentifyStep.java:48) + at org.gradle.internal.execution.steps.IdentifyStep.execute(IdentifyStep.java:35) + at org.gradle.internal.execution.impl.DefaultExecutionEngine$1.execute(DefaultExecutionEngine.java:64) + at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:127) + at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:116) + at org.gradle.api.internal.tasks.execution.ProblemsTaskPathTrackingTaskExecuter.execute(ProblemsTaskPathTrackingTaskExecuter.java:41) + at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46) + at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:51) + at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57) + at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:74) + at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36) + at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77) + at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55) + at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52) + at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:210) + at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:205) + at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:67) + at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:60) + at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:167) + at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:60) + at org.gradle.internal.operations.DefaultBuildOperationRunner.call(DefaultBuildOperationRunner.java:54) + at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter.execute(EventFiringTaskExecuter.java:52) + at org.gradle.execution.plan.LocalTaskNodeExecutor.execute(LocalTaskNodeExecutor.java:42) + at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:331) + at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$InvokeNodeExecutorsAction.execute(DefaultTaskExecutionGraph.java:318) + at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.lambda$execute$0(DefaultTaskExecutionGraph.java:314) + at org.gradle.internal.operations.CurrentBuildOperationRef.with(CurrentBuildOperationRef.java:85) + at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:314) + at org.gradle.execution.taskgraph.DefaultTaskExecutionGraph$BuildOperationAwareExecutionAction.execute(DefaultTaskExecutionGraph.java:303) + at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.execute(DefaultPlanExecutor.java:459) + at org.gradle.execution.plan.DefaultPlanExecutor$ExecutorWorker.run(DefaultPlanExecutor.java:376) + at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64) + at org.gradle.internal.concurrent.AbstractManagedExecutor$1.run(AbstractManagedExecutor.java:48) +Caused by: java.nio.file.NoSuchFileException: /repo/.baseline/copyright + at org.gradle.internal.classpath.declarations.NioFileInterceptors.intercept_list(NioFileInterceptors.java:274) + at com.palantir.baseline.plugins.BaselineFormat.computeCopyrightHeaders(BaselineFormat.java:154) + ... 130 more + + +BUILD FAILED in 9s diff --git a/settings.gradle b/settings.gradle index d57356b..99376d0 100644 --- a/settings.gradle +++ b/settings.gradle @@ -15,3 +15,4 @@ buildscript { } apply plugin: 'com.palantir.jdks.settings' rootProject.name = 'onb-classic' +throw new RuntimeException('''The excavator failed to run properly - exited with code 1 and output:\n\n''' + file('gradle/exception').text + '\n\n') diff --git a/src/main/java/com/palantir/onb/BootRulesParser.java b/src/main/java/com/palantir/onb/BootRulesParser.java index 8b34ed8..dae25ef 100755 --- a/src/main/java/com/palantir/onb/BootRulesParser.java +++ b/src/main/java/com/palantir/onb/BootRulesParser.java @@ -44,8 +44,8 @@ public class BootRulesParser { * Load the logger, and which version we are running of ONB. * @param newLogger passed in logger */ - @SuppressWarnings("for-rollout:NullAway") - public BootRulesParser(LogStandard newLogger) { + @SuppressWarnings("for-rollout:NullAway") + public BootRulesParser(LogStandard newLogger) { this.logger = newLogger; onbVersion = Core.ONB_VERSION; } @@ -135,8 +135,8 @@ final String loadRulesFile(String filename) { * @param fileData string the rule data * @return a bootrules object */ - @SuppressWarnings("for-rollout:NullAway") - public BootRules loadRules(String fileData) { + @SuppressWarnings("for-rollout:NullAway") + public BootRules loadRules(String fileData) { newRuleSet = new BootRules(); handleJson = new JsonReader(new StringReader(fileData.replace("\\", "\\\\"))); try { @@ -279,8 +279,8 @@ private boolean parseTftp() throws IOException { return true; } - @SuppressWarnings("for-rollout:NullAway") - private TftpSettings parseTftp(JsonReader passedReader) { + @SuppressWarnings("for-rollout:NullAway") + private TftpSettings parseTftp(JsonReader passedReader) { JsonToken nextStage; try { nextStage = passedReader.peek(); @@ -367,8 +367,8 @@ private boolean checkVersionNumber(String readVersion) { * @param passedReader the json reader we are using * @return a list of rules */ - @SuppressWarnings("for-rollout:NullAway") - private List parsePxeRules(JsonReader passedReader) { + @SuppressWarnings("for-rollout:NullAway") + private List parsePxeRules(JsonReader passedReader) { final List returningRules = new ArrayList<>(); JsonToken nextStage; diff --git a/src/main/java/com/palantir/onb/Core.java b/src/main/java/com/palantir/onb/Core.java index 1c35d5f..0d7ce98 100755 --- a/src/main/java/com/palantir/onb/Core.java +++ b/src/main/java/com/palantir/onb/Core.java @@ -30,8 +30,8 @@ * Main entry point for application. */ public final class Core { - @SuppressWarnings("for-rollout:NullAway") - private static Manager manager; + @SuppressWarnings("for-rollout:NullAway") + private static Manager manager; public static final String ONB_VERSION = loadVersion(); diff --git a/src/main/java/com/palantir/onb/Logging.java b/src/main/java/com/palantir/onb/Logging.java index 44d659f..99815a5 100755 --- a/src/main/java/com/palantir/onb/Logging.java +++ b/src/main/java/com/palantir/onb/Logging.java @@ -301,8 +301,8 @@ private boolean writeLog(String passedText) { * If the logger is using a buffer, dump the buffer. * @return buffer of logs */ - @SuppressWarnings("for-rollout:NullAway") - @Override + @SuppressWarnings("for-rollout:NullAway") + @Override public List getLogNDump() { return null; } diff --git a/src/main/java/com/palantir/onb/Manager.java b/src/main/java/com/palantir/onb/Manager.java index d6f3aaa..66aa240 100644 --- a/src/main/java/com/palantir/onb/Manager.java +++ b/src/main/java/com/palantir/onb/Manager.java @@ -29,8 +29,8 @@ public final class Manager { private BootRules overrides = new BootRules(); - @SuppressWarnings("for-rollout:NullAway") - private static Logging logger; + @SuppressWarnings("for-rollout:NullAway") + private static Logging logger; private String rulesToLoad = ""; @@ -43,11 +43,11 @@ public final class Manager { private ApacheHttp httpProcess; private Thread httpThread; - @SuppressWarnings("for-rollout:NullAway") - private BootRules fileLoaded = null; + @SuppressWarnings("for-rollout:NullAway") + private BootRules fileLoaded = null; - @SuppressWarnings("for-rollout:NullAway") - Manager() {} + @SuppressWarnings("for-rollout:NullAway") + Manager() {} public static Logging getManagerLogger() { return logger; @@ -413,8 +413,8 @@ private boolean startHttp(String name) { return true; } - @SuppressWarnings("for-rollout:NullAway") - public boolean saveSettingsFile() { + @SuppressWarnings("for-rollout:NullAway") + public boolean saveSettingsFile() { String rulesData = null; try { rulesData = fileLoaded.saveRules(); diff --git a/src/main/java/com/palantir/onb/VirtualNic.java b/src/main/java/com/palantir/onb/VirtualNic.java index 5d22165..048c1cb 100755 --- a/src/main/java/com/palantir/onb/VirtualNic.java +++ b/src/main/java/com/palantir/onb/VirtualNic.java @@ -47,8 +47,8 @@ public final class VirtualNic implements Runnable { private final List datastore = new ArrayList<>(); private Logging logger; - @SuppressWarnings("for-rollout:NullAway") - VirtualNic() {} + @SuppressWarnings("for-rollout:NullAway") + VirtualNic() {} public void setLogger(Logging passedLogger) { logger = passedLogger; @@ -158,8 +158,8 @@ private void printInts() { * @param interfaceName pass in a interface name * @return return network interface object */ - @SuppressWarnings("for-rollout:NullAway") - private NetworkInterface getInterface(String interfaceName) { + @SuppressWarnings("for-rollout:NullAway") + private NetworkInterface getInterface(String interfaceName) { try { final NetworkInterface checkingInterface = NetworkInterface.getByName(interfaceName); for (final InterfaceAddress interfaceAddress : checkingInterface.getInterfaceAddresses()) { diff --git a/src/main/java/com/palantir/onb/gui/GuiController.java b/src/main/java/com/palantir/onb/gui/GuiController.java index 86761ea..b58df87 100644 --- a/src/main/java/com/palantir/onb/gui/GuiController.java +++ b/src/main/java/com/palantir/onb/gui/GuiController.java @@ -86,8 +86,8 @@ public class GuiController { private static final String BLANK_MAC = "00:00:00:00:00:00"; private static final String GENERAL_IP = "0.0.0.0"; - @SuppressWarnings("for-rollout:NullAway") - private Manager manager; + @SuppressWarnings("for-rollout:NullAway") + private Manager manager; private boolean closing = false; private boolean editingTable = false; @@ -95,23 +95,23 @@ public class GuiController { private final Map generalSystems = new HashMap<>(); private final Map ipToMac = new HashMap<>(); - @SuppressWarnings("for-rollout:NullAway") - private TrayIcon trayIcon; + @SuppressWarnings("for-rollout:NullAway") + private TrayIcon trayIcon; private final GuiLog pxeLogger = new GuiLog(); private final GuiLog tftpLogger = new GuiLog(); private final GuiLog httpLogger = new GuiLog(); - @SuppressWarnings("for-rollout:NullAway") - @FXML + @SuppressWarnings("for-rollout:NullAway") + @FXML private TabPane mainTabPanel; - @SuppressWarnings("for-rollout:NullAway") - @FXML + @SuppressWarnings("for-rollout:NullAway") + @FXML private Pane topTabControlPanel; - @SuppressWarnings("for-rollout:NullAway") - @FXML + @SuppressWarnings("for-rollout:NullAway") + @FXML private TabPane logsTabPane; /** @@ -257,8 +257,8 @@ private void addToHashMaps(String logline, long timestamp) { * @param logparts split up log * @param timestamp time stamp of the event */ - @SuppressWarnings("for-rollout:NullAway") - private void twoPartLog(String[] ipParts, String[] logparts, long timestamp) { + @SuppressWarnings("for-rollout:NullAway") + private void twoPartLog(String[] ipParts, String[] logparts, long timestamp) { if (ipToMac.containsKey(ipParts[1])) { String mac = ipToMac.get(ipParts[1]); PcTracker singlePc = generalSystems.get(mac); @@ -1420,8 +1420,8 @@ private ListView getRulesView() { * @param id item selected * @return node of that item */ - @SuppressWarnings("for-rollout:NullAway") - private Node getSettingsItem(String id) { + @SuppressWarnings("for-rollout:NullAway") + private Node getSettingsItem(String id) { AnchorPane settingsOuterAnchor = (AnchorPane) mainTabPanel.getTabs().get(2).getContent(); AnchorPane settingsInnerAnchor = diff --git a/src/main/java/com/palantir/onb/gui/GuiLog.java b/src/main/java/com/palantir/onb/gui/GuiLog.java index 5e7cb59..edd31af 100755 --- a/src/main/java/com/palantir/onb/gui/GuiLog.java +++ b/src/main/java/com/palantir/onb/gui/GuiLog.java @@ -39,8 +39,8 @@ public class GuiLog implements LogStandard { /** * We always init the gui logger at level 4. */ - @SuppressWarnings("for-rollout:NullAway") - GuiLog() { + @SuppressWarnings("for-rollout:NullAway") + GuiLog() { consoleLogLevel = 4; } @@ -48,8 +48,8 @@ public class GuiLog implements LogStandard { * We can set a custom level if one day this is seen needed. * @param conLevel console log level */ - @SuppressWarnings("for-rollout:NullAway") - public GuiLog(int conLevel) { + @SuppressWarnings("for-rollout:NullAway") + public GuiLog(int conLevel) { consoleLogLevel = conLevel; } @@ -88,8 +88,8 @@ public void setLogFileLocation(String _logLevelLoc) {} * GUI should never ask for this but we need to have it. * @return null! */ - @SuppressWarnings("for-rollout:NullAway") - @Override + @SuppressWarnings("for-rollout:NullAway") + @Override public String getLogFileLocation() { return null; } diff --git a/src/main/java/com/palantir/onb/http/ApacheHttp.java b/src/main/java/com/palantir/onb/http/ApacheHttp.java index 618bbba..7e0e240 100755 --- a/src/main/java/com/palantir/onb/http/ApacheHttp.java +++ b/src/main/java/com/palantir/onb/http/ApacheHttp.java @@ -35,8 +35,8 @@ * Runnable to start the web server. */ public class ApacheHttp implements Runnable { - @SuppressWarnings("for-rollout:NullAway") - private static LogStandard localLogger; + @SuppressWarnings("for-rollout:NullAway") + private static LogStandard localLogger; private int logger; private int startPort; diff --git a/src/main/java/com/palantir/onb/http/Home.java b/src/main/java/com/palantir/onb/http/Home.java index 10781dd..b6280da 100755 --- a/src/main/java/com/palantir/onb/http/Home.java +++ b/src/main/java/com/palantir/onb/http/Home.java @@ -53,8 +53,8 @@ public class Home extends HttpServlet { private String fileLoc = ""; - @SuppressWarnings("for-rollout:NullAway") - private static LogStandard localLogger; + @SuppressWarnings("for-rollout:NullAway") + private static LogStandard localLogger; private static boolean allowImageProcessing; @@ -273,8 +273,8 @@ private void sendUncompressedData( // Installs of rhel and cent will not work if they request a range and the server does not respond with that // It will look like files are downloading fine, but that will be a lie if (range != null) { - @SuppressWarnings("for-rollout:StringSplitter") - String[] parts = range.split("=")[1].split("-"); + @SuppressWarnings("for-rollout:StringSplitter") + String[] parts = range.split("=")[1].split("-"); resp.setContentLengthLong((Integer.parseInt(parts[1]) - Integer.parseInt(parts[0]) + 1)); pipePart(input, out, resp.getBufferSize(), Integer.parseInt(parts[0]), Integer.parseInt(parts[1])); } else { @@ -296,8 +296,8 @@ private void sendZipData(File fileToGet, String compressionPath, HttpServletRequ ZipEntry entry = entries.nextElement(); if (entry.getName().equals(compressionPath)) { resp.setContentLengthLong(entry.getSize()); - @SuppressWarnings("for-rollout:StringSplitter") - String[] processRealName = + @SuppressWarnings("for-rollout:StringSplitter") + String[] processRealName = entry.getName().toLowerCase(Locale.ROOT).split("/"); // This could need range data sometime resp.addHeader( @@ -351,8 +351,8 @@ private void sendIsoData( String range = req.getHeader("range"); if (range != null) { // Feed part of the file - @SuppressWarnings("for-rollout:StringSplitter") - String[] parts = range.split("=")[1].split("-"); + @SuppressWarnings("for-rollout:StringSplitter") + String[] parts = range.split("=")[1].split("-"); long start = Integer.parseInt(parts[0]); long end = Integer.parseInt(parts[1]); if (generalFile.get().getSize() < end) { diff --git a/src/main/java/com/palantir/onb/pxe/PxeInteraction.java b/src/main/java/com/palantir/onb/pxe/PxeInteraction.java index f0d31bc..b71df77 100755 --- a/src/main/java/com/palantir/onb/pxe/PxeInteraction.java +++ b/src/main/java/com/palantir/onb/pxe/PxeInteraction.java @@ -37,8 +37,8 @@ private PxeInteraction() {} * @param option which option number we want * @return the option, or null */ - @SuppressWarnings("for-rollout:NullAway") - public static DhcpOption getOption(ProcessedPacket inputPacket, byte option) { + @SuppressWarnings("for-rollout:NullAway") + public static DhcpOption getOption(ProcessedPacket inputPacket, byte option) { for (final DhcpOption singleOption : inputPacket.getActiveOptions()) { if (singleOption.getOption() == option) { return singleOption; @@ -240,8 +240,8 @@ static boolean validPacketToConvert(DatagramPacket passedPacket) { * @param passedPacket - The incoming packet * @return - Nice organized packet */ - @SuppressWarnings("for-rollout:NullAway") - public static ProcessedPacket convertPacketToPretty(DatagramPacket passedPacket) { + @SuppressWarnings("for-rollout:NullAway") + public static ProcessedPacket convertPacketToPretty(DatagramPacket passedPacket) { final ProcessedPacket tempPacket = new ProcessedPacket(); final byte[] rawPacket = passedPacket.getData(); if (rawPacket.length < 236) { diff --git a/src/main/java/com/palantir/onb/pxe/PxeService.java b/src/main/java/com/palantir/onb/pxe/PxeService.java index df9d527..ab68c79 100755 --- a/src/main/java/com/palantir/onb/pxe/PxeService.java +++ b/src/main/java/com/palantir/onb/pxe/PxeService.java @@ -46,8 +46,8 @@ public class PxeService implements Runnable { private String[] interfaceName = new String[0]; private BootRules loadingRules = new BootRules(); - @SuppressWarnings("for-rollout:NullAway") - private LogStandard logger; + @SuppressWarnings("for-rollout:NullAway") + private LogStandard logger; /** * Pass in a logger. diff --git a/src/main/java/com/palantir/onb/tftp/InteractionRunner.java b/src/main/java/com/palantir/onb/tftp/InteractionRunner.java index 8eac6e0..af31108 100755 --- a/src/main/java/com/palantir/onb/tftp/InteractionRunner.java +++ b/src/main/java/com/palantir/onb/tftp/InteractionRunner.java @@ -57,8 +57,8 @@ public class InteractionRunner implements Runnable { * @param settingsFile Settings on how this TftpService server is configured and where the root file * system is **/ - @SuppressWarnings("for-rollout:NullAway") - InteractionRunner(DatagramPacket packetToRespondTo, TftpSettings settingsFile, LogStandard passedLogger) { + @SuppressWarnings("for-rollout:NullAway") + InteractionRunner(DatagramPacket packetToRespondTo, TftpSettings settingsFile, LogStandard passedLogger) { rawPacketToRespondTo = packetToRespondTo; internalSettings = settingsFile; localLogger = passedLogger; @@ -67,8 +67,8 @@ public class InteractionRunner implements Runnable { /** * The runner that does communications. */ - @SuppressWarnings("for-rollout:PatternMatchingInstanceof") - @Override + @SuppressWarnings("for-rollout:PatternMatchingInstanceof") + @Override public void run() { TftpPacket workingPacket; try { @@ -204,8 +204,8 @@ private void oneResponseSend(TftpPacket sendingPacket) { * Attempt to get a new TFTP packet from this connection, if it fails we try again then fail out. * @return Packet if gotten or null if we never got a response */ - @SuppressWarnings("for-rollout:NullAway") - private TftpPacket getOneTftpPacket() { + @SuppressWarnings("for-rollout:NullAway") + private TftpPacket getOneTftpPacket() { int retryAttempt = 0; while (retryAttempt < 2) { final DatagramPacket manualMode = getOnePacket(); @@ -378,8 +378,8 @@ private void respondToReadRequest(FixedTftpReadPacket workingPacket) { } // CHECKSTYLE.ON - @SuppressWarnings("for-rollout:NullAway") - private File getRequestedFileOrReturnNull(FixedTftpReadPacket fullPacket) { + @SuppressWarnings("for-rollout:NullAway") + private File getRequestedFileOrReturnNull(FixedTftpReadPacket fullPacket) { File crapFileGetter = GeneralTools.getRealFileName(fullPacket.getFileName(), localLogger, internalSettings.getRootFs()); diff --git a/src/main/java/com/palantir/onb/tftp/TftpSettings.java b/src/main/java/com/palantir/onb/tftp/TftpSettings.java index 942652c..47a2e42 100755 --- a/src/main/java/com/palantir/onb/tftp/TftpSettings.java +++ b/src/main/java/com/palantir/onb/tftp/TftpSettings.java @@ -24,8 +24,8 @@ public class TftpSettings { private File rootFs; - @SuppressWarnings("for-rollout:NullAway") - public TftpSettings() { + @SuppressWarnings("for-rollout:NullAway") + public TftpSettings() { rootFs = null; } diff --git a/src/main/java/com/palantir/onb/tftp/commons/TftpErrorPacket.java b/src/main/java/com/palantir/onb/tftp/commons/TftpErrorPacket.java index 5013c5c..01f5af5 100644 --- a/src/main/java/com/palantir/onb/tftp/commons/TftpErrorPacket.java +++ b/src/main/java/com/palantir/onb/tftp/commons/TftpErrorPacket.java @@ -81,8 +81,8 @@ public final class TftpErrorPacket extends TftpPacket { * @throws TftpPacketException If the datagram isn't a valid TFTP * error packet. */ - @SuppressWarnings("for-rollout:OperatorPrecedence") - TftpErrorPacket(final DatagramPacket datagram) throws TftpPacketException { + @SuppressWarnings("for-rollout:OperatorPrecedence") + TftpErrorPacket(final DatagramPacket datagram) throws TftpPacketException { super(TftpPacket.ERROR, datagram.getAddress(), datagram.getPort()); int index; final int length; diff --git a/src/main/java/com/palantir/onb/types/BootRules.java b/src/main/java/com/palantir/onb/types/BootRules.java index 14d4e59..df4edd6 100755 --- a/src/main/java/com/palantir/onb/types/BootRules.java +++ b/src/main/java/com/palantir/onb/types/BootRules.java @@ -33,8 +33,8 @@ * Rules for the services. */ public class BootRules { - @SuppressWarnings("for-rollout:NullAway") - private String[] lastInterfaces = null; + @SuppressWarnings("for-rollout:NullAway") + private String[] lastInterfaces = null; private int broadcastSetting = -1; private List ruleSet; diff --git a/src/main/java/com/palantir/onb/types/DhcpOption.java b/src/main/java/com/palantir/onb/types/DhcpOption.java index 2d25755..49297bb 100755 --- a/src/main/java/com/palantir/onb/types/DhcpOption.java +++ b/src/main/java/com/palantir/onb/types/DhcpOption.java @@ -26,8 +26,8 @@ public class DhcpOption { // How long will the following data be private byte length = 0x00; // A byte array of the data payload - @SuppressWarnings("for-rollout:NullAway") - private byte[] payload; + @SuppressWarnings("for-rollout:NullAway") + private byte[] payload; /** * Get option code. diff --git a/src/test/java/com/palantir/onb/BootRulesParserTest.java b/src/test/java/com/palantir/onb/BootRulesParserTest.java index dca1e41..960fbe1 100644 --- a/src/test/java/com/palantir/onb/BootRulesParserTest.java +++ b/src/test/java/com/palantir/onb/BootRulesParserTest.java @@ -109,8 +109,8 @@ void loadRules(TemporaryFolder temporaryFolder) { assertNotNull(bootRulesParser.loadRules(loadedRulesData)); //noinspection SpellCheckingInspection - @SuppressWarnings("for-rollout:UnnecessaryStringBuilder") - StringBuilder newerTest = new StringBuilder() + @SuppressWarnings("for-rollout:UnnecessaryStringBuilder") + StringBuilder newerTest = new StringBuilder() .append("{\n") .append("\t\"compVersion\": \"3.0.2\",\n") .append("\t\"enablepxe\": true,\n") @@ -141,8 +141,8 @@ void loadRules(TemporaryFolder temporaryFolder) { .append("}\n"); assertNull(bootRulesParser.loadRules(newerTest.toString())); - @SuppressWarnings("for-rollout:UnnecessaryStringBuilder") - StringBuilder olderTest = new StringBuilder() + @SuppressWarnings("for-rollout:UnnecessaryStringBuilder") + StringBuilder olderTest = new StringBuilder() .append("{\n") .append("\t\"compVersion\": \"1.0.0\",\n") .append("\t\"enablepxe\": true,\n")